AutoDJ: make 'enable' shortcut work after startup #3242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed two issue I need help with.
and I rather discuss them here to work around launchpad and ease code references.
1) before the AutoDJ hotkey Shift+F12 would toggle [AutoDJ],enable after startup any library feature must have had focus (Ctrl+F to focus the searchbar is sufficient, just ANY trackmodel needs to be selected?)
2) with 'Allow random track addition' disabled the above wouldn't work either:
= log "Debug[Main] Queue is empty now"
from https://github.com/mixxxdj/mixxx/blob/2.3/src/library/autodj/autodjprocessor.cpp#L403
because getNextTrackFromQueue() returns 0 even though the queue holds enough tracks.
= AutoDJ starts
2 is solved with change added here: m_pAutoDJTableModel->select(); in autodjprocessor.
Though this is just a hack, I have no idea about the implications.
For 1 I have no idea..