Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoDJ: make 'enable' shortcut work after startup #3242

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 31, 2020

I noticed two issue I need help with.
and I rather discuss them here to work around launchpad and ease code references.

1) before the AutoDJ hotkey Shift+F12 would toggle [AutoDJ],enable after startup any library feature must have had focus (Ctrl+F to focus the searchbar is sufficient, just ANY trackmodel needs to be selected?)

2) with 'Allow random track addition' disabled the above wouldn't work either:

2 is solved with change added here: m_pAutoDJTableModel->select(); in autodjprocessor.
Though this is just a hack, I have no idea about the implications.

For 1 I have no idea..

@daschuer
Copy link
Member

daschuer commented Nov 1, 2020

A controller that has mapped [AutoDJ],enabled is also affected.

I think that it is sufficient that m_pAutoDJTableModel->select(); is called once.

@ronso0
Copy link
Member Author

ronso0 commented Nov 2, 2020

what about

  1. before the AutoDJ hotkey Shift+F12 would toggle [AutoDJ],enable after startup any library feature must have had focus

I doubt the change here fixes it for controllers as the shortcut is not working.
Where else do we need to m_pAutoDJTableModel->select(); ?

Previously, one first had to focus a library widget and also enable
random track addition (even though the AutoDJ queue was populated).
@ronso0 ronso0 changed the title [WIP] AutoDJ hotkey AutoDJ: make 'enable' shortcut work after startup Nov 2, 2020
@ronso0 ronso0 marked this pull request as ready for review November 2, 2020 21:49
@ronso0
Copy link
Member Author

ronso0 commented Nov 2, 2020

@daschuer Works beautifully, ready for review!

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for taking care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants