Shift+F12 should toggle AutoDJ regardless if AutoDJ feature was selecter ealier

[mixxxbot]

Reported by: ronso0
Date: 2020-04-04T16:39:35Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1870817
Tags: autodj, library

---

to reproduce (1):
(make sure there are tracks in the AutoDJ playlist, quit Mixxx)

• start Mixxx
• don't click anything, just hit Shift+F12 (toggle AutoDJ)
  = nothing happens*
• open AutoDJ feature
• hit Shift+F12
  = AutoDJ starts

to reproduce (2):
(make sure there are tracks in the AutoDJ playlist, quit Mixxx)

• start Mixxx
• don't click anything, just hit Shift+F12 (toggle AutoDJ)
  = nothing happens*
• from anywhere, add track to AutoDJ queue
• hit Shift+F12
  = AutoDJ starts

*Log message is Queue is empty nowfrom AutoDJProcessor::toggleAutoDJ(bool)
https://github.com/mixxxdj/mixxx/blob/master/src/library/autodj/autodjprocessor.cpp#L399

[mixxxbot]

Commented by: ronso0
Date: 2020-04-04T16:41:51Z

---

Adding m_pAutoDJTableModel->select() at the very top of AutoDJProcessor::getNextTrackFromQueue() fixes the issue.
https://github.com/mixxxdj/mixxx/blob/master/src/library/autodj/autodjprocessor.cpp#L826

I'm not sure if this the correct fix, but m_pAutoDJTableModel->select(); is also called in DlgAutoDJ::onShow()
https://github.com/mixxxdj/mixxx/blob/master/src/library/autodj/dlgautodj.cpp#L219

[mixxxbot]

Commented by: ronso0
Date: 2020-11-10T17:23:05Z

---

#3242

[mixxxbot]

Issue closed with status Fix Released.