Remove runtime dynamic loading of libmp3lame in favor of compile-time linking. #1802
Conversation
| class LAME(Dependence): | ||
| def configure(self, build, conf): | ||
| if not conf.CheckLib(['libmp3lame', 'libmp3lame-static']): | ||
| raise Exception("Could not find libmp3lame.") |
There was a problem hiding this comment.
Do we want to make this optional instead of required?
There was a problem hiding this comment.
I think we probably always want an MP3 encoder since the recording feature is non-optional and the broadcast feature is always enabled in our releases, so I don't see a reason to make it optional. Plus it would take more work to make it optional because the existing code that handled lame not being dynamically loadable was super hacky (just throws up modal error message boxes instead of properly graying out the MP3 option in the preferences).
|
Waiting on a Windows environment re-build because lame.h was installed to the wrong place. |
… linking. Fixes Launchpad Bug #1294128.
Ok, should be fixed after 7d9b4bd. |
|
@JosepMaJAZ has tested the x64 build on Windows 7. I believe this is ready to merge. |
|
LGTM! Thank you. |
Fixes Launchpad Bug #1294128.