Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle LAME mp3 plugin required for Recording and Streaming #7341

Closed
mixxxbot opened this issue Aug 22, 2022 · 8 comments
Closed

Bundle LAME mp3 plugin required for Recording and Streaming #7341

mixxxbot opened this issue Aug 22, 2022 · 8 comments
Labels
broadcast Bugs pertaining to streaming radio broadcaster use-case feature mp3 recording usability
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: esbrandt
Date: 2014-03-18T13:33:44Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp1294128
Tags: broadcast, mp3, recording, usability


"How to obtain and install the mp3 codec, because Recording and Streaming mp3 wont work?"
This is one of the most common support request.

We would do many users and ourselves a favor, if we finally make the whole process user friendly. The current way of downloading from unreliable 3rd-party sites, renaming files and copying to the correct location is error prone, and should be a thing of the past.

I understand that we can not distribute lame binaries, be we can sideload, like in other apps.

Proposal:
If user tries to activate mp3 streaming/recording, do not only display a popup with links too wiki/manual, but allow to download and install the correct codec to the expected location by the click of a single button.

@mixxxbot mixxxbot added broadcast Bugs pertaining to streaming radio broadcaster use-case feature mp3 recording usability labels Aug 22, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2017-06-23T11:45:08Z


Now that Fraunhofer IIS terminated the MP3 patent-licensing program [1], we can seek to have the mp3 codec legally bundled by default. Fraunhofer recommend [2] to get in touch [3] for official query.

[1] https://www.iis.fraunhofer.de/en/ff/amm/prod/audiocodec/audiocodecs/mp3.html
[2] http://www.audioblog.iis.fraunhofer.com/mp3-software-patents-licenses/
[3] https://www.iis.fraunhofer.de/en/ff/amm/prod/audiocodec/audiocodecs/mp3.html#tabpanel-2

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2017-06-23T20:08:41Z


This is how fedora deals with it.
https://fedoramagazine.org/full-mp3-support-coming-soon-to-fedora/

I think we can now just bundle LAME, without a risk to being sued.

I thing we should continue to go with lame, because it is still "maintained" and known to work well.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2017-06-24T05:17:56Z


Nice, changed subject accordingly.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2018-04-17T18:52:40Z


mixxxdj/buildserver#32

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2018-09-13T22:34:53Z


mixxxdj/buildserver@0017c2a

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2018-09-13T22:44:54Z


#1802

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2018-09-18T22:24:07Z


Manual updates: mixxxdj/manual#73

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Bugs pertaining to streaming radio broadcaster use-case feature mp3 recording usability
Projects
None yet
Development

No branches or pull requests

1 participant