Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"com" and "prf" in coinbase from wallet #3416

Closed
wants to merge 1 commit into from

Conversation

antiochp
Copy link
Member

@antiochp antiochp commented Aug 7, 2020

Resolves: mimblewimble/grin-wallet#499

We ask the wallet for a CbData (output and kernel for block reward).

The output looks like this -

	"output": {
		"com": "08fe198e525a5937d0c5d01fa354394d2679be6df5d42064a0f7550c332fce3d9d",
		"features": 1,
		"prf": "9d8488fc..."
	}

It used to look like this -

	"output": {
		"commit": "08fe198e525a5937d0c5d01fa354394d2679be6df5d42064a0f7550c332fce3d9d",
		"features": "Coinbase",
		"proof": "9d8488fc..."
	}

This PR adds an alias to both commit and proof via a custom CbOutput.
For convenience we ignore the output features (and kernel features) as this wallet api will only return coinbase specific output and kernel.
This code is only used for this single wallet api call.

Tested locally on usertesting and confirmed the node can talk to the wallet successfully (both on master).

@antiochp
Copy link
Member Author

antiochp commented Aug 7, 2020

Closing. We should fix this on wallet side to maintain compatibility between old nodes and new wallet.

Resolved in - mimblewimble/grin-wallet#503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: build_coinbase returns invalid output features
1 participant