"com" and "prf" in coinbase from wallet #3416
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: mimblewimble/grin-wallet#499
We ask the wallet for a
CbData
(output and kernel for block reward).The output looks like this -
It used to look like this -
This PR adds an
alias
to bothcommit
andproof
via a customCbOutput
.For convenience we ignore the output features (and kernel features) as this wallet api will only return coinbase specific output and kernel.
This code is only used for this single wallet api call.
Tested locally on
usertesting
and confirmed the node can talk to the wallet successfully (both onmaster
).