build_coinbase api fix and cleanup #505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #499.
Related: mimblewimble/grin#3416.
V4 cleanup introduced a breaking change to the
CbData
response.Old -
New -
This PR ensures we now produce the expected json when node requests
CbData
viabuild_coinbase
.We actually no longer need
TransactionV4
and the various related data structures.This PR cleans this up, allowing the use of a simplified
CoinbaseV4
with nestedCbOutputV4
andCbKernelV4
.I was initially going to add an alternative "compat" ser/deser for output features along the same lines as the exsiting "compat" kernel features. But we do not actually need this as
CbData
and the version specificCoinbaseV4
is the only place this would be required.