This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating React components for
br
elements and specifying children as per usual, React will warn later that void elements such asbr
should not have children.This PR ensures that React components created from
br
elements are created without children and adds a test for it as well.Additionally, I made sure to decode HTML entities of text nodes before handing them over to
React.createElement
as the latter will do its own encoding (and in effect double encode HTML entities), as well as adding a .editorconfig file for ease of editing.