This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Deal with void element tags #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2016
Closed
|
Nice 👍 |
| @@ -101,6 +101,25 @@ describe('Html2React', function() { | |||
|
|
|||
| assert.equal(reactHtml, htmlExpected); | |||
| }); | |||
|
|
|||
| it('should parse br elements without warnings', function() { | |||
There was a problem hiding this comment.
I think you should've kept the wording in my PR, e.g. that the test asserts that children aren't created for void elements, as this is more direct.
|
@aknuds1 I've added the test case from your PR to cover your notes. Thanks for the feedback. |
|
Looking forward to this one - thanks! Fixes #29. |
|
Any chance of seeing this in a new release anytime soon? As it stands, non existing support for void tags is kinda sorta a deal breaker for an otherwise really useful library. |
|
would really like to see the PRs here getting merged. |
|
Fixes #29 as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #13, but a bit more generic. It also fixes parts of #8.
Status: Ready for review
Reviewers: @lithin @aknuds1
Changes