Stop compressing names in RT records #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although RFC 1183 allows names in the RT record to be compressed with: "The concrete encoding is identical to the MX RR." RFC 3597 specifically prohibits compressing names in any record not defined in RFC 1035.
tmthrgd
commented
Nov 30, 2018
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
==========================================
+ Coverage 57.9% 57.96% +0.06%
==========================================
Files 42 42
Lines 10661 10675 +14
==========================================
+ Hits 6173 6188 +15
+ Misses 3399 3398 -1
Partials 1089 1089
Continue to review full report at Codecov.
|
|
you need to 'go install' at the right moment, because the generating code looks there for the new definition instead of the current dir with the new types.go |
|
@miekg Well that worked, I had no idea, how odd. |
|
Lgtm
…On Fri, 30 Nov 2018, 10:52 Tom Thorogood ***@***.*** wrote:
***@***.**** commented on this pull request.
------------------------------
In types.go <#847 (comment)>:
> @@ -353,7 +353,7 @@ func (rr *X25) String() string {
type RT struct {
Hdr RR_Header
Preference uint16
- Host string `dns:"cdomain-name"`
+ Host string `dns:"domain-name"`
@miekg <https://github.com/miekg> Done.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#847 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVkW52XPFIx6ZK9zzAz27w89B0C-r4xks5u0Q39gaJpZM4Y6wNx>
.
|
This was referenced Dec 1, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although RFC 1183 allows names in the RT record to be compressed with:
But RFC 3597 specifically prohibits compressing names in any record not defined in RFC 1035.
Note: I had to modify the two generated files by hand as they weren't picking up my changes to types.go for some reason. There shouldn't be any changes running
go generatelater though.Updates #522