Add NULL record

[miekg]

Sorely missing from this library. Add it.

[codecov-io]

Codecov Report

Merging #840 into master will decrease coverage by 0.04%.
The diff coverage is 47.82%.

@@            Coverage Diff            @@
##           master    #840      +/-   ##
=========================================
- Coverage   57.25%   57.2%   -0.05%     
=========================================
  Files          41      41              
  Lines       10534   10583      +49     
=========================================
+ Hits         6031    6054      +23     
- Misses       3422    3441      +19     
- Partials     1081    1088       +7

Impacted Files	Coverage Δ
types.go	73.66% <0%> (-0.34%)	⬇️
zduplicate.go	4.31% <0%> (-0.05%)	⬇️
ztypes.go	45.22% <25%> (-0.26%)	⬇️
msg_helpers.go	57% <60%> (+0.07%)	⬆️
zmsg.go	48.05% <70%> (+0.18%)	⬆️
acceptfunc.go	40% <0%> (-1.18%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5f238...8d8e57e. Read the comment docs.

[tmthrgd]

@miekg Can this wait until #833? That changes the signature of len and it would be much easier to rebase this PR rather than #833.

[miekg]

[ Quoting <notifications@github.com> in "Re: [miekg/dns] WIP: Add NULL recor..." ]

@miekg Can this wait until #833? That changes the signature of `len` and it would be much easier to rebase this PR rather than #833.

yeah, this can wait.

[miekg]

rebased and regenerated. Only needs a little test. Hard to validate if the implementation is interopereable because there is no presentation format.

[tmthrgd]

go install + go generate. You're not picking up the changes from #847.

[tmthrgd]

Could you add a test against a fixed record data that was generated by something else?

[miekg]

I don't know how another DNS implementations can be made to generate these, but I'll take a look

…

On Sat, 1 Dec 2018, 10:20 Tom Thorogood ***@***.*** wrote: Could you add a test against a fixed record data that was generated by something else? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#840 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVkW3BhgnVAbrx8XfOo4Lg5zDnig_h7ks5u0lgEgaJpZM4Y4TBB> .

[tmthrgd]

If they’re used by tunneling implementations, maybe one of those could be used to generate the record? It’s not obvious without a presentation format.

[tmthrgd]

At the very least, you could add a regression test by using this implementation to generate the record to make sure it doesn’t accidentally change.

[tmthrgd]

@miekg I think you need to update gofmt, see https://golang.org/doc/go1.11#gofmt. The original formatting of these lines was correct as of go1.11.

[miekg]

[ Quoting <notifications@github.com> in "Re: [miekg/dns] Add NULL record (#8..." ]

tmthrgd requested changes on this pull request. > - `t.example.com. IN TXT "abc" "DEF"`: "t.example.com.\t3600\tIN\tTXT\t\"abc\" \"DEF\"", - `t.example.com. IN TXT "abc" ( "DEF" )`: "t.example.com.\t3600\tIN\tTXT\t\"abc\" \"DEF\"", - `t.example.com. IN TXT aaa ;`: "t.example.com.\t3600\tIN\tTXT\t\"aaa\"", - `t.example.com. IN TXT aaa aaa;`: "t.example.com.\t3600\tIN\tTXT\t\"aaa\" \"aaa\"", - `t.example.com. IN TXT aaa aaa`: "t.example.com.\t3600\tIN\tTXT\t\"aaa\" \"aaa\"", - `t.example.com. IN TXT aaa`: "t.example.com.\t3600\tIN\tTXT\t\"aaa\"", + `t.example.com. IN TXT ""`: "t.example.com.\t3600\tIN\tTXT\t\"\"", + `t.example.com. IN TXT "a"`: "t.example.com.\t3600\tIN\tTXT\t\"a\"", + `t.example.com. IN TXT "aa"`: "t.example.com.\t3600\tIN\tTXT\t\"aa\"", + `t.example.com. IN TXT "aaa" ;`: "t.example.com.\t3600\tIN\tTXT\t\"aaa\"", + `t.example.com. IN TXT "abc" "DEF"`: "t.example.com.\t3600\tIN\tTXT\t\"abc\" \"DEF\"", + `t.example.com. IN TXT "abc" ( "DEF" )`: "t.example.com.\t3600\tIN\tTXT\t\"abc\" \"DEF\"", + `t.example.com. IN TXT aaa ;`: "t.example.com.\t3600\tIN\tTXT\t\"aaa\"", + `t.example.com. IN TXT aaa aaa;`: "t.example.com.\t3600\tIN\tTXT\t\"aaa\" \"aaa\"", + `t.example.com. IN TXT aaa aaa`: "t.example.com.\t3600\tIN\tTXT\t\"aaa\" \"aaa\"", + `t.example.com. IN TXT aaa`: "t.example.com.\t3600\tIN\tTXT\t\"aaa\"", @miekg I think you need to update `gofmt`, see https://golang.org/doc/go1.11#gofmt. The original formatting of these lines was correct as of go1.11.

ah.. I was wondering about this. Must be ages since I go-installed gofmt

[miekg]

ok, conflict resolved and rebased (manually edited zmsg.go, because it can't 'go install' the right version of the go library to make go generate work). PTAL

[miekg]

@tmthrgd I think this is good to go

[tmthrgd]

Aside from that one nit, this LGTM.