-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename mgt-tasks to mgt-planner #2890
Conversation
renames component to better suit current usage removes dead code calling deprecated Graph APIs for Outlook Tasks moves a number of strings into the localizable string collection for the component updates the generate script for mgt-react to clean files at the start of generation BREAKING CHANGE: mgt-tasks has been removed and replaced with mgt-planner. mgt-planner does not support data-source switching to fetch data from the outlook tasks apis any longer.
📖 The updated storybook is available here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An interesting behavior (I don't know if it's related to the component rename). When moving from "Assigned to me" to a specific plan, if the plan has no tasks, the UI doesn't update and "sticks" with the previous set of tasks. For instance: And then when I click on Server MTL-001 is broken, I get the same set of tasks, but just in another view? So it looks like it's not updating the tasks based on the user's selection. |
Oh that's an interesting find @sebastienlevert Does mgt-tasks behave that way on https://mgt.dev/next ? If so, then let's address it as a separate work item. |
Actually, it looks like the filtering is profoundly broken in main at the moment. |
Filtering issue is tracked by #2893 |
📖 The updated storybook is available here |
📖 The updated storybook is available here |
|
📖 The updated storybook is available here |
The image for the dot options has been fixed in the todo change from @Mnickii |
Closes #2889 #2321
PR Type
Description of the changes
renames component to better suit current usage
removes dead code calling deprecated Graph APIs for Outlook Tasks moves a number of strings into the localizable string collection for the component updates the generate script for mgt-react to clean files at the start of generation
BREAKING CHANGE: mgt-tasks has been removed and replaced with mgt-planner. mgt-planner does not support data-source switching to fetch data from the outlook tasks apis any longer.
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information