Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize strings used in mgt-task components #2321

Closed
noumanfarooq566 opened this issue May 16, 2023 · 5 comments · Fixed by #2890
Closed

Localize strings used in mgt-task components #2321

noumanfarooq566 opened this issue May 16, 2023 · 5 comments · Fixed by #2890
Assignees
@gavinbarron
Labels
feature-request State: In Review

Comments

@noumanfarooq566
Copy link

noumanfarooq566 commented May 16, 2023 •
edited by gavinbarron
Loading

Can we localize 'Assigned to me' text that is in mgt-task component? In documentation there are only 4 strings that we are said to be localizable which doesn't contain 'assigned to me', is there any way to localize it?

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
@github-actions
Copy link

This issue has been assigned to you, @sebastienlevert. You are listed as the author for the document associated with this issue. If this is not correct, please take the following actions.

  • Assign this issue to the correct author
  • Create a pull request to update the author field in the YAML front-matter of this topic

@sebastienlevert sebastienlevert transferred this issue from another repository May 17, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Graph Toolkit May 17, 2023
@ghost ghost added the Needs: Triage 🔍 label May 17, 2023
@ghost
Copy link

ghost commented May 17, 2023

Hello noumanfarooq566, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@sebastienlevert
Copy link
Contributor

Hello @noumanfarooq566. I transfered the issue directly to the MGT repo. Thanks for the feedback! We'll be looking into it! Are there other labels you see that we should localize?

Also, would you be willing to make the change and send a PR our way?

@gavinbarron gavinbarron changed the title Can we localize 'Assigned to me' text that is in mgt-task component? In documentation there are only 4 strings that we are said to be localizable which doesn't contain 'assigned to me', is there any way to localize it? Localize strings used in mgt-task components Jul 19, 2023
@gavinbarron gavinbarron moved this from Needs Triage 🔍 to Proposed 💡 in Graph Toolkit Jul 19, 2023
@gavinbarron
Copy link
Member

Currently there are a lot of labels defined in the TASK_RES constant on line 118.

These need to be migrate to the strings file to allow for proper localization, there will need to be some refactoring to allow for common lookups across both Tasks and Planner

@sebastienlevert sebastienlevert removed their assignment Jul 20, 2023
@gavinbarron gavinbarron linked a pull request Nov 30, 2023 that will close this issue
feat: rename mgt-tasks to mgt-planner #2890
Merged
6 tasks
@gavinbarron gavinbarron mentioned this issue Nov 30, 2023
Merged
6 tasks
@gavinbarron
Copy link
Member

We're improving the localization support in this component as part of the rename of it to mgt-planner

@github-project-automation github-project-automation bot moved this from Proposed 💡 to Done ✔️ in Graph Toolkit Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavinbarron gavinbarron

Labels
feature-request State: In Review
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rename mgt-tasks to mgt-planner microsoftgraph/microsoft-graph-toolkit
3 participants
@gavinbarron @sebastienlevert @noumanfarooq566