-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fill AppsAndFeaturesEntries in Google.JapaneseIME old version #144449
Merged
microsoft-github-policy-service
merged 1 commit into
microsoft:master
from
kachick:Google.JapaneseIME-2.28.4650.0-fill-missing-fields
Mar 15, 2024
Merged
Fix: Fill AppsAndFeaturesEntries in Google.JapaneseIME old version #144449
microsoft-github-policy-service
merged 1 commit into
microsoft:master
from
kachick:Google.JapaneseIME-2.28.4650.0-fill-missing-fields
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
According to what was pointed out in #144281 (comment)
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
wingetbot
added
Manifest-Version-Deprecated
This manifest schema version is deprecated. The PR should be updated.
Azure-Pipeline-Passed
Validation pipeline passed. There may still be manual validation requirements.
Validation-Completed
Validation passed
labels
Mar 15, 2024
Manifest Schema Version: 1.1.0 less than 1.5.0 for ID: Google.JapaneseIME and Version: 2.28.4650.0 |
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
This needs a response from the author.
label
Mar 15, 2024
Should I follow the new schema even if just fix the current definition? |
microsoft-github-policy-service
bot
added
Needs-Attention
This work item needs to be reviewed by a member of the core team.
and removed
Needs-Author-Feedback
This needs a response from the author.
labels
Mar 15, 2024
[Policy] Reset Feedback |
microsoft-github-policy-service
bot
removed
the
Needs-Attention
This work item needs to be reviewed by a member of the core team.
label
Mar 15, 2024
[Policy] Approved |
microsoft-github-policy-service
bot
added
the
Moderator-Approved
One of the Moderators has reviewed and approved this PR
label
Mar 15, 2024
microsoft-github-policy-service
bot
merged commit Mar 15, 2024
95d91b2
into
microsoft:master
8 checks passed
Thank you! |
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure-Pipeline-Passed
Validation pipeline passed. There may still be manual validation requirements.
Manifest-Version-Deprecated
This manifest schema version is deprecated. The PR should be updated.
Moderator-Approved
One of the Moderators has reviewed and approved this PR
Publish-Pipeline-Succeeded
Validation-Completed
Validation passed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to what was pointed out in #144281 (comment)
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.AppsAndFeaturesEntries
by Komac is same as2.29.5370.0
AppsAndFeaturesEntries
Microsoft Reviewers: Open in CodeFlow