Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fill AppsAndFeaturesEntries in Google.JapaneseIME old version #144449

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix: Fill AppsAndFeaturesEntries in Google.JapaneseIME old version #144449

merged 1 commit into from
Mar 15, 2024

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Mar 15, 2024

According to what was pointed out in #144281 (comment)

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Manifest-Version-Deprecated This manifest schema version is deprecated. The PR should be updated. Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 15, 2024
@wingetbot
Copy link
Collaborator

Manifest Schema Version: 1.1.0 less than 1.5.0 for ID: Google.JapaneseIME and Version: 2.28.4650.0

@kachick
Copy link
Contributor Author

kachick commented Mar 15, 2024

Should I follow the new schema even if just fix the current definition?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 15, 2024
@Trenly
Copy link
Contributor

Trenly commented Mar 15, 2024

[Policy] Reset Feedback

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 15, 2024
@Trenly
Copy link
Contributor

Trenly commented Mar 15, 2024

[Policy] Approved

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 95d91b2 into microsoft:master Mar 15, 2024
8 checks passed
@kachick
Copy link
Contributor Author

kachick commented Mar 15, 2024

Thank you!

@kachick kachick deleted the Google.JapaneseIME-2.28.4650.0-fill-missing-fields branch March 15, 2024 14:46
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manifest-Version-Deprecated This manifest schema version is deprecated. The PR should be updated. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants