Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Google.JapaneseIME version 2.29.5370.0 #144281

Merged
merged 2 commits into from
Mar 15, 2024
Merged

New version: Google.JapaneseIME version 2.29.5370.0 #144281

merged 2 commits into from
Mar 15, 2024

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Mar 14, 2024

Pull request has been created with komac v2.1.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kachick
Copy link
Contributor Author

kachick commented Mar 14, 2024

@microsoft-github-policy-service agree

@kachick

This comment was marked as outdated.

@kachick kachick marked this pull request as draft March 14, 2024 08:51
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kachick kachick changed the title New version: Google.JapaneseIME version 2.29.5374.0 New version: Google.JapaneseIME version 2.29.5370.0 Mar 14, 2024
@kachick kachick marked this pull request as ready for review March 14, 2024 09:12
@kachick kachick marked this pull request as draft March 14, 2024 09:44
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Mar 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 14, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Mar 14, 2024
@kachick kachick marked this pull request as ready for review March 14, 2024 12:02
@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 14, 2024
@wingetbot
Copy link
Collaborator

=== manifests\g\Google\JapaneseIME\2.29.5370.0 ===
Missing Properties value based on version 2.28.4650.0:
MinimumOSVersion

@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) March 14, 2024 13:05
@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Mar 14, 2024
auto-merge was automatically disabled March 14, 2024 16:11

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. New-Manifest Manifest-Metadata-Consistency labels Mar 14, 2024
@kachick
Copy link
Contributor Author

kachick commented Mar 14, 2024

=== manifests\g\Google\JapaneseIME\2.29.5370.0 ===
Missing Properties value based on version 2.28.4650.0:
MinimumOSVersion

I have checked the returned value from Google API

<os platform="win" version="11" arch="x64" />

this and version=10 returns same URLs and filename, but specified version=8 and version=7 returns error-osnotsupported

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) March 14, 2024 17:10
@stephengillie
Copy link
Collaborator

stephengillie commented Mar 15, 2024

Hi @kachick,

This manifest adds Apps and Features entries that aren't present in previous PR versions. These entries should be added to the previous versions, or removed from this version.

(Automated response - build 870.)

Edit: Sorry for my out of date message. This PR adds DisplayName and UpgradeCode neither of which I believe cause an issue if they're only in one PR.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 898db5d into microsoft:master Mar 15, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 15, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@kachick
Copy link
Contributor Author

kachick commented Mar 15, 2024

Thanks for your reviewing merging!

This PR adds DisplayName and UpgradeCode neither of which I believe cause an issue if they're only in one PR.

2.28.4650.0 manifest uses v1.1.0 schema, it looks like providing the fields.

https://github.com/microsoft/winget-cli/blob/7cea3d9582f9bd68a4406c73f07309b1df79f120/schemas/JSON/manifests/v1.1.0/manifest.installer.1.1.0.json#L386-L427

So adding these entries in old version is also needed? I'll try 💪

AppsAndFeaturesEntries:
- DisplayName: Google 日本語入力
  UpgradeCode: '{C1A818AF-6EC9-49EF-ADCF-35A40475D156}'

@kachick kachick deleted the Google.JapaneseIME-2.29.5374.0-8C202F5403524C31BEC448A131283897 branch March 15, 2024 03:05
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants