Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For full CLR TargetFrameworks make DebugType is 'Full' #528

Merged
merged 2 commits into from
Feb 22, 2017
Merged

For full CLR TargetFrameworks make DebugType is 'Full' #528

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e80478
For full CLR TargetFrameworks make DebugType is 'Full'
smadala Feb 21, 2017
f614110
Use TargetFrameworkIdentifier instead TargetFramework.
smadala Feb 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/Microsoft.NET.Test.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,24 @@
<GenerateProgramFile Condition="'$(GenerateProgramFile)' == ''">true</GenerateProgramFile>
</PropertyGroup>

<!-- Output type for dotnet core test project should be exe. For full CLR it is Library by default.
This should be added in props file.
Issues: https://github.com/dotnet/roslyn-project-system/issues/268,
https://devdiv.visualstudio.com/DevDiv/_workitems?id=375688&_a=edit
<!--
Output type for dotnet core test project should be exe. For full CLR it is Library by default.
This should be added in props file.
Issues: https://github.com/dotnet/roslyn-project-system/issues/268,
https://devdiv.visualstudio.com/DevDiv/_workitems?id=375688&_a=edit
-->
<PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
<OutputType>Exe</OutputType>
</PropertyGroup>

<!--
In IDE scenario for full CLR projects default test platform is v1, which expects full pdbs for source information.
This can be removed once TPv2 is default for full CLR. Related issue https://github.com/Microsoft/vstest/issues/373.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm a little confused, I thought TP V2 is the default for the new project system projects targeting Full CLR as well. Is that understanding wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tpv2 is default for netcore, for net46 need to add testplatform.config.

-->
<PropertyGroup>
<DebugType Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">Full</DebugType>
</PropertyGroup>

<!--
Note that this must run before every invocation of CoreCompile to ensure that all
compiler runs see the generated Program file. Furthermore, we must run *after*
Expand Down