For full CLR TargetFrameworks make DebugType is 'Full' #528
Conversation
|
Hi @smadala, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
src/Microsoft.NET.Test.Sdk.targets
Outdated
| This can be removed once TPv2 is default for full CLR. Related issue https://github.com/Microsoft/vstest/issues/373. | ||
| --> | ||
| <PropertyGroup> | ||
| <DebugType Condition="'$(TargetFramework)' != '' AND !$(TargetFramework.StartsWith('netcoreapp'))">Full</DebugType> |
There was a problem hiding this comment.
Use TargetFrameworkIdentifier instead?
| --> | ||
| <PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'"> | ||
| <OutputType>Exe</OutputType> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- | ||
| In IDE scenario for full CLR projects default test platform is v1, which expects full pdbs for source information. | ||
| This can be removed once TPv2 is default for full CLR. Related issue https://github.com/Microsoft/vstest/issues/373. |
There was a problem hiding this comment.
Sorry I'm a little confused, I thought TP V2 is the default for the new project system projects targeting Full CLR as well. Is that understanding wrong?
There was a problem hiding this comment.
Tpv2 is default for netcore, for net46 need to add testplatform.config.
* For full CLR TargetFrameworks make DebugType is 'Full' * Use TargetFrameworkIdentifier instead TargetFramework.
Tested Manually.
Related bugs: #373 & #523
This change is