Fix assembly loading in symbol loader #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of attempting to load the test assembly, try to query for it. It should have been already loaded by the test adapter. In netcoreapp1.1, attempting to load the same executable within itself throws.
smadala
reviewed
Jan 18, 2017
| // At this point, the assembly should be already loaded into the load context. We query for a reference to | ||
| // find the types and cache the symbol information. Let the loader follow default lookup order instead of | ||
| // forcing load from a specific path. | ||
| var asm = Assembly.Load(AssemblyLoadContext.GetAssemblyName(binaryPath)); |
There was a problem hiding this comment.
Please run Platform tests DiaSessionTests.
smadala
approved these changes
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of attempting to load the test assembly, try to query for it. It should
have been already loaded by the test adapter.
In netcoreapp1.1, attempting to load the same executable within itself throws.
This fix is a port from RC.3 branch. See #332.
Validation scenarios: