Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect DebugType setting #1301

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Remove incorrect DebugType setting #1301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/package/nuspec/Microsoft.NET.Test.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,6 @@
<PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
<OutputType>Exe</OutputType>
</PropertyGroup>

<!--
In IDE scenario for full CLR projects default test platform is v1, which expects full pdbs for source information.
This can be removed once TPv2 is default for full CLR. Related issue https://github.com/Microsoft/vstest/issues/373.
-->
<PropertyGroup>
<DebugType Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">Full</DebugType>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this before fixing #800 breaks code coverage for .NET Full framework. We can change the condition to add Full debug type if user not specified.

Copy link
Member Author

@tmat tmat Nov 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smadala This is not the right place to change DebugType value. As I pointed out by the time this is evaluated its original value has already been used to calculate other variables.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting next sprint, we will begin the work to add code coverage support for .NET Core in the presence of portable and embedded PDBs.

@tmat, in the meantime we will merge in this PR.

</PropertyGroup>

<!--
Generate config file for test project targeting .NET Framework. This config file has binding redirect which is needed at time of running tests.
Expand Down Expand Up @@ -93,4 +85,4 @@
<Compile Include="$(GeneratedProgramFile)"/>
</ItemGroup>
</Target>
</Project>
</Project>