Remove incorrect DebugType setting #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livarcocc
approved these changes
Nov 17, 2017
smadala
reviewed
Nov 17, 2017
| This can be removed once TPv2 is default for full CLR. Related issue https://github.com/Microsoft/vstest/issues/373. | ||
| --> | ||
| <PropertyGroup> | ||
| <DebugType Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">Full</DebugType> |
There was a problem hiding this comment.
Removing this before fixing #800 breaks code coverage for .NET Full framework. We can change the condition to add Full debug type if user not specified.
There was a problem hiding this comment.
@smadala This is not the right place to change DebugType value. As I pointed out by the time this is evaluated its original value has already been used to calculate other variables.
There was a problem hiding this comment.
Starting next sprint, we will begin the work to add code coverage support for .NET Core in the presence of portable and embedded PDBs.
@tmat, in the meantime we will merge in this PR.
smadala
approved these changes
Nov 18, 2017
|
@smadala Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove incorrect DebugType setting.
Currently the targets file sets
DebugTypeafter it has been used by the SDK to determine whether symbols need to be copied to the output directory. If the project setsDebugTypetoembeddedthe SDK determines that no PDBs need to be copied but then the test SDK overwritesDebugTypevalue which makes the compiler to produce Windows PDB. This PDB is not copied to the output directory. XUnit will not find it there when displaying stack traces so the stack traces will miss line and file information.Related issue
Fixes #373