Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use events instead of PPromise for search IPC #53536

Merged
merged 3 commits into from
Jul 9, 2018
Merged

Use events instead of PPromise for search IPC #53536

merged 3 commits into from
Jul 9, 2018

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Jul 4, 2018 •
edited
Loading

I'm removing PPromise support from the IPC layer. This removes the usage of PPromise in Search's IPC layer and replaces it with events.

We still need to remove Search's use of PPromise... but it'll have to come later.

@joaomoreno joaomoreno added debt Code quality issues search Search widget and operation issues labels Jul 4, 2018
@joaomoreno joaomoreno added this to the July 2018 milestone Jul 4, 2018
@joaomoreno joaomoreno self-assigned this Jul 4, 2018
@joaomoreno joaomoreno requested review from roblourens and chrmarti July 4, 2018 13:31
@joaomoreno joaomoreno mentioned this pull request Jul 4, 2018
Merged
11 tasks
roblourens
roblourens reviewed Jul 8, 2018
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. I assume I'm responsible for extHostSearch.ts and everything internal to search.

@joaomoreno joaomoreno merged commit 8bc931b into master Jul 9, 2018
@joaomoreno joaomoreno deleted the joao/search-progress-events branch July 9, 2018 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens left review comments

@chrmarti chrmarti Awaiting requested review from chrmarti

Assignees

@joaomoreno joaomoreno

Labels
debt Code quality issues search Search widget and operation issues
Projects
None yet
Milestone
July 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@joaomoreno @roblourens