Remove PPromise

[joaomoreno]

This PR aims to remove the usage of progress of WinJS Promises.

The first commit removes the type definitions for progress, so this branch will remain broken until we remove all its usage.

• Remove PPromise types
• Remove usage of PPromise
  • Theme picker @joaomoreno
  • IPC events @joaomoreno
  • Search IPC Use events instead of PPromise for search IPC #53536 @joaomoreno
  • QuickInput @joaomoreno
  • QuickOpenController @joaomoreno
  • File Watcher Remove PPromise usage from NSFW IPC #53556 Remove ppromise usage from chokidar #53584 @joaomoreno
  • IPC (when all above are fixed) @joaomoreno
  • Tasks Remove PPromise usage from task world #53875 @dbaeumer
  • Search @roblourens

[joaomoreno]

Down to 38 errors only... I've updated the first comment with checkboxes on the areas left to adopt. Please go through your area and replace usages of promise progress with simple callbacks.

[joaomoreno]

Removed Search IPC PPromise usage, awaiting review: #53536 cc @roblourens @chrmarti

[jens1o]

What will be the advantage of this?

[joaomoreno]

@jens1o This is just engineering debt. More details: #53526

[joaomoreno]

Created #53875 for the task world. Search is all that's left.

[roblourens]

Filed #53887 on myself

[connorshea]

so is removing it from search done now 🤔

[roblourens]

👍

[joaomoreno]

Sweet! Moving this to next week.

[joaomoreno]

@roblourens This is the last PPromise usage:

https://github.com/Microsoft/vscode/blob/remove-ppromise/src/vs/workbench/api/node/extHostSearch.fileIndex.ts#L419

Is it as simple as removing , onBatch from that then call?

[roblourens]

Oops, yes done

[joaomoreno]

Thanks for all the help guys! 🎆