-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use patched emmet to support svg and orphaned quote bug #19655
Conversation
f6f5f7a
to
934f0d5
Compare
@egamma ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good move.
Thanks @egamma! |
is a good idea to use a patch/custom fork? |
@gianpaj We did try to use the latest v1.6.1 of emmet, but there was almost a 4 times increase in the size of the emmet module when comparing 1.3.1 (version currently used by VS Code) and the latest 1.6.1 You can read more at #9002 (comment) Also, the emmet author is currently working on v2.0 with significant API changes. Therefore, we took the call to not take that latest version of emmet. Now since we didnt want to wait till v2.0 was out to fix #8135, we took the forked approach. From now till v2.0 is out, it is unlikely that the fork is going to be changed unless there is a major bug fix to be taken |
Hi @ramya-rao-a, that makes perfect sense. Thanks very much for explaining the reasoning behind :) |
Fixes #17166 and #11333 and #8135