Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patched emmet to support svg and orphaned quote bug #19655

Merged
merged 1 commit into from
Feb 7, 2017

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Feb 1, 2017

Fixes #17166 and #11333 and #8135

@ramya-rao-a
Copy link
Contributor Author

@egamma ping

Copy link
Member

@egamma egamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good move.

@ramya-rao-a
Copy link
Contributor Author

Thanks @egamma!

@gianpaj
Copy link

gianpaj commented Feb 7, 2017

is a good idea to use a patch/custom fork?
looks like emmet fixed this on v1.6.1: emmetio/emmet#477 (comment)

@ramya-rao-a
Copy link
Contributor Author

@gianpaj We did try to use the latest v1.6.1 of emmet, but there was almost a 4 times increase in the size of the emmet module when comparing 1.3.1 (version currently used by VS Code) and the latest 1.6.1

You can read more at #9002 (comment)

Also, the emmet author is currently working on v2.0 with significant API changes.

Therefore, we took the call to not take that latest version of emmet.

Now since we didnt want to wait till v2.0 was out to fix #8135, we took the forked approach.

From now till v2.0 is out, it is unlikely that the fork is going to be changed unless there is a major bug fix to be taken

@gianpaj
Copy link

gianpaj commented Feb 8, 2017

Hi @ramya-rao-a,

that makes perfect sense. Thanks very much for explaining the reasoning behind :)

@ramya-rao-a ramya-rao-a mentioned this pull request Feb 23, 2017
@ramya-rao-a ramya-rao-a deleted the ramyar/emmet-patch branch April 25, 2017 02:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orphaned quote crashes Sass
5 participants