Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet: svg abbreviations dont work #11333

Closed
ramya-rao-a opened this issue Aug 31, 2016 · 4 comments
Closed

Emmet: svg abbreviations dont work #11333

ramya-rao-a opened this issue Aug 31, 2016 · 4 comments
Assignees
Labels
emmet Emmet related issues feature-request Request for new features or functionality
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Aug 31, 2016

Update: We can now support svg abbreviations but only after mapping the current language mode to "svg" in emmet.syntaxProfiles setting.

We should investigate having svg as an embedded language like we do for html inside jsx

Testing #11139

  • VSCode Version: 1.5.0- Insiders (dated 8/31)
  • OS Version: Windows 10

Steps to Reproduce:

  1. Create svg file. Type gl and hit TAB

As per the abbreviations in lib/snippets.json#L892, gl should have expanded to <glyph>
Instead, it expands to <gl></gl>

Same result with other abbreviations for svg

Similarly, if you associate any language with svg syntax profile, you cannot get any abbreviations expansion.

@ramya-rao-a
Copy link
Contributor Author

This might be because the svg files are associated with xml language mode.

Other file types like haml, slim, sass, styl and stylus have plaintext as their language mode. But none of these have any extra abbreviations or snippets like svg. Therefore one can set xml or css as language mode for these file types to get xml/html emmet features.

But svg has loads of extra emmet abbreviations that we are losing out on.

@mrmlnc
Copy link
Contributor

mrmlnc commented Aug 31, 2016

@ramya-rao-a,

Unfortunately, we do not support SVG with Emmet.

VS Code used Emmet v1.3.1 (see package.json#L19), but support for SVG in Emmet was added in version 1.4.0 (see emmet/6efa2234cd3a72a9bd1232fa79783a878d556107).

More details on this issue: #9002 (comment).

@ramya-rao-a
Copy link
Contributor Author

With #19655 we can now support svg abbreviations but only after mapping the current language mode to "svg" in emmet.syntaxProfiles setting.

We should investigate having svg as an embedded language like we do for html inside jsx

@egamma egamma assigned ramya-rao-a and unassigned egamma Feb 23, 2017
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, February 2017 Feb 24, 2017
@ramya-rao-a ramya-rao-a added the feature-request Request for new features or functionality label Apr 17, 2017
@rebornix rebornix removed the editor label May 2, 2017
@ramya-rao-a
Copy link
Contributor Author

Closing this issue as there is no sufficient interest from the community in getting this done.
We can revisit if there is any interest in the future

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emmet Emmet related issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants