Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support emoji IMEs in the terminal #131921

Closed
Tyriar opened this issue Aug 30, 2021 · 2 comments
Closed

Support emoji IMEs in the terminal #131921

Tyriar opened this issue Aug 30, 2021 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 30, 2021

Right now the Windows emoji IME (win+.) seems to work fine but the macOS one does not (ctrl+cmd+space).

Upstream: xtermjs/xterm.js#469

Related #35266
@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) macos Issues with VS Code on MAC/OS X terminal General terminal issues that don't fall under another label upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Aug 30, 2021
@Tyriar Tyriar added this to the September 2021 milestone Aug 30, 2021
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Aug 30, 2021
@Tyriar Tyriar closed this as completed in d891afd Sep 14, 2021
@jrieken jrieken added the verified Verification succeeded label Sep 28, 2021
@bobby169
Copy link

🤩 great work! 🥳

1 similar comment
@bobby169
Copy link

🤩 great work! 🥳

@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
xterm@4.14.0-beta.22
fa85b77 
Commit: d32c6db9676b2b771afb9267a0fad1d6b5fdec57

Fixes microsoft#131921
Fixes microsoft#82489
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2021
Development

No branches or pull requests
5 participants
@jrieken @Tyriar @bobby169 @meganrogge and others