Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji don't work in native Windows shells (WSL is fine) #35266

Closed
mjbvz opened this issue Sep 27, 2017 · 29 comments
Closed

Emoji don't work in native Windows shells (WSL is fine) #35266

mjbvz opened this issue Sep 27, 2017 · 29 comments
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code terminal-conpty Integrated terminal issues related to the ConPTY backend upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream windows VS Code on Windows issues

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 27, 2017

  • VSCode Version: Code - Insiders 1.17.0-insider (e059563, 2017-09-27T09:56:06.042Z)
  • OS Version: Windows_NT x64 10.0.17004

Steps to Reproduce:

  1. Bring up the emoji keyboard in windows
  2. Select vscode terminal and try clicking on an emoji to insert it

Bug
Corrupted Unicode characters are inserted

a

@mjbvz mjbvz added terminal General terminal issues that don't fall under another label windows VS Code on Windows issues labels Sep 27, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2017

Upstream: xtermjs/xterm.js#469

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Sep 28, 2017
@Tyriar Tyriar added this to the Backlog milestone Sep 28, 2017
@KillyMXI
Copy link
Contributor

Looks like it's not even possible to paste emoji from clipboard.
And it also breaks everything if you paste combined characters...

@Tyriar
Copy link
Member

Tyriar commented Dec 28, 2017

@KillyMXI pasting emoji should work, it works differently to in the editor though. The representation of the emoji depends on the shell (eg. bash) which may have patchy support for combined emojis.

@KillyMXI
Copy link
Contributor

KillyMXI commented Dec 28, 2017

Checked it once again.
OK, pasting is shell dependent. I think I was focused on GHCi at that moment. It works in PowerShell, although doesn't accommodate additional space for emojis (doubled character width for them would be nice in monospaced environment with majority of fonts). No combined emojis - OK, that must be tricky enough stuff for now.

But I meant any combined characters. Here I paste two characters - one is a single Unicode symbol and the other one is made of "e" symbol and combining acute accent mark:

Cursor position is not synced with display after that.
(Should I open a separate issue for that?)

@warpdesign
Copy link
Contributor

It's not a windows only issue. Same problem with macOS: #38064.

@Tyriar Tyriar added the macos Issues with VS Code on MAC/OS X label Dec 29, 2017
@Tyriar Tyriar changed the title Windows emoji keyboard does not work with integrated terminal Windows and macOS emoji keyboards do not work with integrated terminal Sep 12, 2018
@mzkev
Copy link

mzkev commented Oct 24, 2018

I cant bring up the emoji keyboard in vscode on windows. Has this been fixed yet?

@gertcuykens
Copy link

Doesn't seem to be fixed

image

image

Version: 1.29.1 (user setup)
Commit: bc24f98
Date: 2018-11-15T19:13:36.375Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

matchai/spacefish#118

@warpdesign
Copy link
Contributor

warpdesign commented Feb 20, 2019

It still doesn't work in macOS either:

  • using the Emoji panel from macOS to insert an Emoji does nothing at all
  • pasting an Emoji kinda works but there are problems: if several Emoji are pasted, using backspace after, too many characters are removed and you can even remove part of the prompt

@Tyriar Tyriar changed the title Windows and macOS emoji keyboards do not work with integrated terminal Support emoji IMEs in the integrated terminal Apr 29, 2019
@lgarron
Copy link

lgarron commented Sep 23, 2019

I've also had trouble inserting emoji on macOS. I assumed I was doing something wrong or had a transient issue, but I still see the same issues that @warpdesign describes. :-(

@Tyriar Tyriar added intergrated-terminal-xtermjs upstream-issue-linked This is an upstream issue that has been reported upstream and removed macos Issues with VS Code on MAC/OS X windows VS Code on Windows issues intergrated-terminal-xtermjs labels Oct 8, 2019
@Ciantic
Copy link

Ciantic commented Dec 3, 2019

I'm used to having Haskell prompt with a pickle (for obvious reasons) in front:

:set prompt "🥒 >>> "

It works with VSCode when it's running bash e.g. inside docker container development. But it ceases to working when I use it inside Powershell in Windows.

Just giving me:

🥒 >>>

I think this is some Powershell/Windows problem.

@stam
Copy link

stam commented Jan 8, 2020

This bug requires me to switch to Iterm and leave my vscode focus in order to commit, would love a fix

@Dc9894
Copy link

Dc9894 commented May 1, 2020

I don't think it's just related to the shell you are using I'm using powershell core as the default integrated terminal and though I can get some emojis typed in there, the characters before and after look weird if shown at all

@slinkardbrandon
Copy link

Today I got really sad when I couldn't commit with an emoji, guys this is breaking people's hearts.

@windcheck
Copy link

Using Windows Terminal powershell runs without problems. When I go to VS code integrated powershell it's broken. See screenshot.

stack1

@ynechaev
Copy link

This issue has nothing to do with PowerShell or VSCode, it's actually related to xtermjs issue xtermjs/xterm.js#469 and it was mentioned above.

@Tyriar
Copy link
Member

Tyriar commented Oct 29, 2020

Note that this issue is about emoji IMEs which are the popup you can use to input emojis. Simple support for them is patchy because WT and conpty seem to do something a little different to what they're trying to emoji, that's tracked in xtermjs/xterm.js#2693

@regalstreak
Copy link

Any workaround for this? @Tyriar Been facing this for years

@andy3520
Copy link

😟 Still cannot add awesome emoji to git commit by using ctrl+cmd+space. I have to use source control in the vscode or insert the emoji some then copy + paste it to the terminal

@jv-k
Copy link

jv-k commented Dec 29, 2020

This is a good workaround until the 🐞 is fixed:

https://marketplace.visualstudio.com/items?itemName=bierner.emojisense

Works in the terminal as well. In MacOS you can use cmd + i to bring up the emoji panel and easily insert.

@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2021

Our support right now seems about as good as Windows terminal, the emoji selector doesn't work but you can write emojis to the terminal. Below shows the second one input via the emoji IME (win+.)

image

WT:

image

@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2021

Message sent to pwsh 7.0.1:

image

Message received from pwsh 7.0.1:

image

@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2021

Related: PowerShell/PowerShell#15256

@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2021

Ok this is definitely an upstream issue: microsoft/terminal#190

FWIW emoji support works fine in wsl which proves we're doing the right thing (plus mac/linux works fine):

image

I'll keep this open as it's a pretty big issue but it's just tracking the upstream issue.

@Tyriar Tyriar added windows VS Code on Windows issues and removed bug Issue identified by VS Code Team member as probable bug labels Jul 16, 2021
@Tyriar Tyriar changed the title Support emoji IMEs in the integrated terminal Emoji don't work on Windows shells Jul 16, 2021
@Tyriar Tyriar added the terminal-conpty Integrated terminal issues related to the ConPTY backend label Jul 16, 2021
@Tyriar Tyriar changed the title Emoji don't work on Windows shells Emoji don't work in native Windows shells (WSL is fine) Jul 16, 2021
@ullaskunder3
Copy link

@Tyriar sir is there any fix?
2021 still the same problem in vs code default bash terminal
If I add emoji from Win emoji picker it just show <?>
image

@erhanertem
Copy link

@Tyriar sir is there any fix? 2021 still the same problem in vs code default bash terminal If I add emoji from Win emoji picker it just show <?> image

Use powershell therminal in vscode....It works fine. Bash still problematic.

@Tyriar Tyriar removed the terminal General terminal issues that don't fall under another label label Dec 9, 2022
@Tyriar
Copy link
Member

Tyriar commented Dec 7, 2023

Closing this in favor of the upstream issue since there's no further action on us to support this: microsoft/terminal#190

@Tyriar Tyriar closed this as completed Dec 7, 2023
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code terminal-conpty Integrated terminal issues related to the ConPTY backend upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests