Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused setting disablePromptForFeatures #1574

Merged
merged 1 commit into from
May 7, 2018

Conversation

DonJayamanne
Copy link

Fixes #1551

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this doesn't seem to be referenced anywhere else. Looks good. Code cleanup FTW. 👍

@codecov
Copy link

codecov bot commented May 3, 2018

Codecov Report

Merging #1574 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
+ Coverage   71.65%   71.66%   +<.01%     
==========================================
  Files         273      273              
  Lines       12700    12697       -3     
  Branches     2282     2281       -1     
==========================================
- Hits         9100     9099       -1     
+ Misses       3465     3463       -2     
  Partials      135      135
Impacted Files Coverage Δ
src/client/common/configSettings.ts 87.95% <ø> (-0.22%) ⬇️
src/client/common/types.ts 100% <ø> (ø) ⬆️
src/client/debugger/mainV2.ts 75.8% <0%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5127486...11d5b7f. Read the comment docs.

@DonJayamanne DonJayamanne merged commit e5c4bf7 into microsoft:master May 7, 2018
@DonJayamanne DonJayamanne deleted the issue1551 branch June 20, 2018 03:14
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated properties (python.disablePromptForFeatures)
2 participants