Remove unused setting disablePromptForFeatures (#1574)

Fixes #1551

news/3 Code Health/1551.md

@@ -0,0 +1 @@
+Remove unused setting `disablePromptForFeatures`.

package.json

@@ -1156,26 +1156,6 @@
                     "description": "Whether to check if Python is installed (also warn when using the macOS-installed Python).",
                     "scope": "resource"
                 },
-                "python.disablePromptForFeatures": {
-                    "type": "array",
-                    "default": [],
-                    "description": "Do not display a prompt to install these features",
-                    "items": {
-                        "type": "string",
-                        "default": "pylint",
-                        "description": "Feature",
-                        "enum": [
-                            "flake8",
-                            "mypy",
-                            "pep8",
-                            "pylama",
-                            "prospector",
-                            "pydocstyle",
-                            "pylint"
-                        ]
-                    },
-                    "scope": "resource"
-                },
                 "python.envFile": {
                     "type": "string",
                     "description": "Absolute path to a file containing environment variable definitions.",

src/client/common/configSettings.ts

@@ -29,7 +29,6 @@ export class PythonSettings extends EventEmitter implements IPythonSettings {
     public jediPath = '';
     public jediMemoryLimit = 1024;
     public envFile = '';
-    public disablePromptForFeatures: string[] = [];
     public venvPath = '';
     public venvFolders: string[] = [];
     public devOptions: string[] = [];
@@ -136,9 +135,6 @@ export class PythonSettings extends EventEmitter implements IPythonSettings {
 
         // tslint:disable-next-line:no-backbone-get-set-outside-model no-non-null-assertion
         const lintingSettings = systemVariables.resolveAny(pythonSettings.get<ILintingSettings>('linting'))!;
-        // tslint:disable-next-line:no-backbone-get-set-outside-model no-non-null-assertion
-        this.disablePromptForFeatures = pythonSettings.get<string[]>('disablePromptForFeatures')!;
-        this.disablePromptForFeatures = Array.isArray(this.disablePromptForFeatures) ? this.disablePromptForFeatures : [];
         if (this.linting) {
             Object.assign<ILintingSettings, ILintingSettings>(this.linting, lintingSettings);
         } else {

src/client/common/types.ts

@@ -111,7 +111,6 @@ export interface IPythonSettings {
     readonly sortImports?: ISortImportSettings;
     readonly workspaceSymbols: IWorkspaceSymbolSettings;
     readonly envFile: string;
-    readonly disablePromptForFeatures: string[];
     readonly disableInstallationChecks: boolean;
     readonly globalModuleInstallation: boolean;
 }