Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] The Quick Fix... link on wrong #include always jumps to the English interface #4677

Closed
Wanye1062271859 opened this issue Nov 29, 2019 · 6 comments
Labels
bug external Language Service world ready An issue relating string character encodings, localization translations, etc.
Milestone

Comments

@Wanye1062271859
Copy link

  1. Install VSCode in a Chinese Simplified machine

  2. Open VSCode and install extension "C/C++"

  3. Open a folder which contain a cpp file

  4. Include a non-existing header file to the cpp file , like #include "TestHeader.h"

  5. Hover the cursor on the #include "TestHeader.h"

  6. Click "Quick Fix..." on the intellisense tips window
    image

  7. Click "Learn how to install a library for this header with vcpkg" to open the web page

Expected:
The page "https://docs.microsoft.com/**zh-cn**/cpp/build/vcpkg?view=vs-2019" was opened
image

Actual:
The English page "The page "https://docs.microsoft.com/**en-us**/cpp/build/vcpkg?view=vs-2019" was opened" opened
image

Notes:
Even if setting the explorer language to Chinese, the link still jump to English page

@sean-mcmanus
Copy link
Contributor

We currently just use "https://aka.ms/vcpkg" -- looks like the fix would be to either generate a new aka link for every language or just use the target URI with the language part inserted.

@sean-mcmanus sean-mcmanus added bug Language Service world ready An issue relating string character encodings, localization translations, etc. labels Dec 2, 2019
@bobbrow bobbrow added this to the Backlog milestone Jan 16, 2020
@v-ericawu
Copy link

@bobbrow @sean-mcmanus A new related issue has arisen since version C/C++ 1.17.2:
The 'Learn how to install a library for this header with vcpkg' option has disappeared from C/C++ extension 1.17.2 to the latest version now, so is this by design?

  • If it's not by design, do we need to file a new GitHub issue to track this new issue?
  • If it's by design, then should we close that Github issue? (because that github issue(4677) needs to click on the 'Learn how to install a library for this header with vcpkg' option to reproduce it)

Latest C/C++ extension version: 1.20.5
image

C/C++ extension 1.17.2:
image

C/C++ extension 1.16.3: 'Learn how to install a library for this header with vcpkg' option appear
image

@sean-mcmanus
Copy link
Contributor

@v-ericawu Yeah, I think there's a new bug caused by the PR #11280 . I think it was only supposed to exclude that code action for system headers.

@v-ericawu
Copy link

v-ericawu commented Jun 25, 2024

@sean-mcmanus Thanks for your confirmation! We have filed a new issue to track the regression issue.

@v-ericawu
Copy link

Tested on C/C++ extension v1.22.0-dogfood1: Clicking on 'Learn how to install a library for this header with vcpkg' opens a link to https://vcpkg.io/en/ and is still not localized:
image

@bobbrow
Copy link
Member

bobbrow commented Sep 3, 2024

The old site was removed and replaced with vcpkg.io which does not have translations for any other languages. This is not an issue for the C++ extension to address right now.

@bobbrow bobbrow closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
@github-project-automation github-project-automation bot moved this to Done in cpptools Sep 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug external Language Service world ready An issue relating string character encodings, localization translations, etc.
Projects
Status: Done
Development

No branches or pull requests

4 participants