-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] The Quick Fix... link on wrong #include always jumps to the English interface #4677
Comments
We currently just use "https://aka.ms/vcpkg" -- looks like the fix would be to either generate a new aka link for every language or just use the target URI with the language part inserted. |
@bobbrow @sean-mcmanus A new related issue has arisen since version C/C++ 1.17.2:
Latest C/C++ extension version: 1.20.5 C/C++ extension 1.16.3: 'Learn how to install a library for this header with vcpkg' option appear |
@v-ericawu Yeah, I think there's a new bug caused by the PR #11280 . I think it was only supposed to exclude that code action for system headers. |
@sean-mcmanus Thanks for your confirmation! We have filed a new issue to track the regression issue. |
Tested on C/C++ extension v1.22.0-dogfood1: Clicking on 'Learn how to install a library for this header with vcpkg' opens a link to https://vcpkg.io/en/ and is still not localized: |
The old site was removed and replaced with vcpkg.io which does not have translations for any other languages. This is not an issue for the C++ extension to address right now. |
Install VSCode in a Chinese Simplified machine
Open VSCode and install extension "C/C++"
Open a folder which contain a cpp file
Include a non-existing header file to the cpp file , like #include "TestHeader.h"
Hover the cursor on the #include "TestHeader.h"
Click "Quick Fix..." on the intellisense tips window
![image](https://user-images.githubusercontent.com/29274719/69846854-55212100-12b0-11ea-8d66-63deaf8497f3.png)
Click "Learn how to install a library for this header with vcpkg" to open the web page
Expected:
![image](https://user-images.githubusercontent.com/29274719/69847175-5868dc80-12b1-11ea-819c-484643c6a5cd.png)
The page "https://docs.microsoft.com/**zh-cn**/cpp/build/vcpkg?view=vs-2019" was opened
Actual:
![image](https://user-images.githubusercontent.com/29274719/69847259-88b07b00-12b1-11ea-8eb8-554342f25472.png)
The English page "The page "https://docs.microsoft.com/**en-us**/cpp/build/vcpkg?view=vs-2019" was opened" opened
Notes:
Even if setting the explorer language to Chinese, the link still jump to English page
The text was updated successfully, but these errors were encountered: