Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] The 'Learn how to install a library for this header with vcpkg' option has disappeared #12413

Closed
v-ericawu opened this issue Jun 25, 2024 · 5 comments
Assignees
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release
Milestone

Comments

@v-ericawu
Copy link

Environment

  • OS and Version: Windows/Linux/Mac OS
  • VS Code Version: 1.85.0
  • C/C++ Extension Version: 1.20.5

Bug Summary and Steps to Reproduce

Bug Summary: The 'Learn how to install a library for this header with vcpkg' option has disappeared

Steps to reproduce:

  1. Create a Test folder with .cpp file.
  2. Open Test folder with VS Code.
  3. Type error code in .cpp file, such as: #include"xxxxx.h"
  4. Hover over error squiggle and Click on 'Quick Fix'

Expected behavior: 'Learn how to install a library for this header with vcpkg' option appear
image

Actual behavior: 'Learn how to install a library for this header with vcpkg' option has disappeared from C/C++ extension 1.17.2

Latest C/C++ extension version: 1.20.5
image

C/C++ extension 1.17.2:
image

Configuration and Logs

/

Other Extensions

/

Additional context

No response

@browntarik
Copy link
Contributor

browntarik commented Jun 26, 2024

Thank you for reporting this issue. This behavior is actually by design as we only want to suggest this code action for headers that are supported by vcpkg.

This does however bring to light a bug where this code action is not appearing even for such headers like #include <zlib.h>.

It looks like we were incorrectly parsing our vcpkg header database. Please keep tracking this issue to be notified when a fix is checked in.

@browntarik browntarik moved this from In progress to Pull Request in cpptools Jun 26, 2024
@browntarik browntarik added the fixed Check the Milestone for the release in which the fix is or will be available. label Jun 27, 2024
@browntarik browntarik moved this from Pull Request to Done in cpptools Jun 27, 2024
@sean-mcmanus sean-mcmanus added this to the 1.21.1 milestone Jul 6, 2024
@sean-mcmanus
Copy link
Contributor

@v-ericawu
Copy link
Author

@sean-mcmanus Verified on C/C++ 1.21.1(pre-release) still repro this issue, so could you help to re-confirm it?
image

@Colengms
Copy link
Contributor

Hi @v-ericawu . To clarify, you wouldn't get that option for "xxxxx.h". The feature applies only if the header is from a library supported by vcpkg. Try geos.h:

image

@v-ericawu
Copy link
Author

@Colengms @sean-mcmanus Thanks for your confirmation! using ''geos.h'' will bring up the 'Learn how to install a library for this header with vcpkg' option:
image

@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release
Projects
Status: Done
Development

No branches or pull requests

4 participants