Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake Tools Initial experience [exp] #3732

Merged
merged 12 commits into from
May 9, 2024

Conversation

gcampbell-msft
Copy link
Collaborator

This experimentally address #3588.

The goal of this PR is to make the initial experience of opening a folder that could potentially use the CMake Tools extension better.

This includes making it easier and more obvious to use the cmake.ignoreCMakeListsMissing setting. This is done by adding an option in the quick pick to not see the quick pick again. Additionally, it we check to confirm that there is actually a CMakeLists.txt in the folder structure based on the same parameters as our activation events, before popping the quick pick.

Lastly, we are experimentally removing the pop-ups that ask "Would you like to configure?", in favor of defaulting cmake.configureOnOpen to true.

@gcampbell-msft gcampbell-msft changed the title Dev/gcampbell/c make tools init experiment Update CMake Tools Initial experience [exp] May 1, 2024
@gcampbell-msft gcampbell-msft marked this pull request as draft May 1, 2024 18:36
@gcampbell-msft gcampbell-msft force-pushed the dev/gcampbell/CMakeToolsInitExperiment branch from b486118 to 4374c73 Compare May 6, 2024 18:19
@gcampbell-msft gcampbell-msft force-pushed the dev/gcampbell/CMakeToolsInitExperiment branch from 4374c73 to ac51168 Compare May 6, 2024 19:28
@gcampbell-msft gcampbell-msft marked this pull request as ready for review May 6, 2024 19:34
@gcampbell-msft gcampbell-msft enabled auto-merge (squash) May 9, 2024 21:04
@gcampbell-msft gcampbell-msft merged commit 6124d26 into main May 9, 2024
4 checks passed
@gcampbell-msft gcampbell-msft deleted the dev/gcampbell/CMakeToolsInitExperiment branch May 9, 2024 21:05
@i-ky
Copy link
Contributor

i-ky commented Jun 20, 2024

Lastly, we are experimentally removing the pop-ups that ask "Would you like to configure?", in favor of defaulting cmake.configureOnOpen to true.

This does not provide the best experience if the project is supposed to be developed in container. There is no guarantee that configure will succeed while the folder is opened on host, because some of the required tools may only be installed in dev container and not on the host.

This can be worked around by setting cmake.configureOnOpen to false in .vscode/settings.json and to true in .devcontainer/devcontainer.json in customizations.vscode.settings, but this is a little bit awkward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants