Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake extension does not prompt to select CmakeLists.txt file in 1.17 #3588

Closed
sinemakinci1 opened this issue Feb 13, 2024 · 3 comments
Closed
Assignees
Labels
bug a bug in the product
Milestone

Comments

@sinemakinci1
Copy link
Contributor

Brief Issue Summary

in 1.17, even when there is a CMakeLists.txt file, the Cmake Tools extension does not activate. An example repo I used can be found here: https://github.com/sinemakinci1/basic-cpp-copilot-example/tree/main/my-cmake-project
image

Since CMakeLists.txt file is embedded not at the top-level, it should prompt me to select a CMakeLists.txt file (this is part of the partial activation experience). Once I downgraded to 1.15, I saw the prompt, selected my CMakeList.txt file and kits, and now 1.16 and 1.17 versions of CMake Tools extension activate with the project.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

@sinemakinci1 sinemakinci1 added the bug a bug in the product label Feb 13, 2024
@github-project-automation github-project-automation bot moved this to Triage Needed in CMake Tools Feb 13, 2024
@gcampbell-msft gcampbell-msft moved this from Triage Needed to Pending Prioritization in CMake Tools Feb 14, 2024
@gcampbell-msft gcampbell-msft added this to the On Deck milestone Feb 14, 2024
@sinemakinci1
Copy link
Contributor Author

The hypothesis is that this came from a community PR to disable selecting CMakeList.txt when it is not in your root. We need to bring back that dropdown to some degree

@YuriL180821
Copy link

@sinemakinci1 could you please provide any workaround to fix the problem locally on user's PC?

@gcampbell-msft gcampbell-msft modified the milestones: On Deck, 1.18 Feb 20, 2024
@sinemakinci1
Copy link
Contributor Author

@YuriL180821 Can you try the following?

  1. Set this setting in your settings.json
    “cmake.sourceDirectory” : “${workspaceFolder}/<insert path to where the CMakeLists.txt lives in this project>”.

Then, reload the window and see if VSC will prompt for youto configure? Once prompted, you should press Yes, and see an option to select a CMakeLists.txt file up top (if embedded in a subdirectory).

In general, if you have the CMake Tools extension installed, you should be able to find the CMake: Configure command in the command palette which will fire that option to select a CMakeLists.txt file if detected in a sub-directory.

@gcampbell-msft gcampbell-msft moved this from Pending Prioritization to Ready to be Assigned in CMake Tools Apr 2, 2024
@gcampbell-msft gcampbell-msft self-assigned this Apr 11, 2024
@gcampbell-msft gcampbell-msft moved this from Ready to be Assigned to In Progress in CMake Tools Apr 11, 2024
@gcampbell-msft gcampbell-msft moved this from In Progress to Completed in CMake Tools May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the product
Projects
Status: Completed
Development

No branches or pull requests

3 participants