Respect the startup info state initially passed to wt via ShellExecute
#13838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is got so brboken" This reverts commit 103beb4.
This hooks up the defterm interface to pass more info along in the startup. It's notably not the actual link title, but it does work from a plumbing standpoint This is for #9458
…rtupInfoToTerminal
…rtupInfoToTerminal
…rtupInfoToTerminal
…rtupInfoToTerminal
This reverts commit 1fac403.
…t-3-the-actual-doing-of-the-thing
|
|
oh it was so much easier than that |
This comment has been minimized.
This comment has been minimized.
…t-3-the-actual-doing-of-the-thing
…t-3-the-actual-doing-of-the-thing
zadjii-msft
added a commit
that referenced
this pull request
Apr 20, 2023
We had a report in a mail thread that someone's Terminal windows were getting created hidden, and never showing themselves. As a theory, I'm guessing that dwFlags didn't say that we should actually use `wShowWindow`. So, to be more correct, let's actually obey that. I'm gonna send this package to them to see if it fixes them. Related to #14957. Likely regressed in #13838.
zadjii-msft
added a commit
that referenced
this pull request
Apr 25, 2023
We had a report in a mail thread that someone's Terminal windows were getting created hidden, and never showing themselves. As a theory, I'm guessing that dwFlags didn't say that we should actually use `wShowWindow`. So, to be more correct, let's actually obey that. I'm gonna send this package to them to see if it fixes them. Related to #14957. Likely regressed in #13838.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original description, pre-process model v3:
More accurately:
This PR enables terminal windows to use the
wShowCmdfrom the STARTUPINFO passed towindowsterminal.exeto set the initial visibility of the window. We can't just useSW_SHOWDEFAULT, because all the windows are running in the initial process! After the first window, the subsequent ones would ignore any params passed to their originatingwindowsterminal.exeprocesses. To mitigate, we pass thatwShowCmdinfo from the source process, to the actual running terminal process. That accounts for most of the delta here.Closes #9053
This doesn't do the same for defterm-initiated connections. This is because we don't need to! Defterm very explicitly rejects handoff for minimized console apps. This is probably for the best! I put an attempt in 66f8b25 before I forgot that it was filtered long before the Terminal. NOT doing this for /min saves us all sorts of "what happens if
start /min cmdtries to glom?" or "what if someone doesstart /min cmd && start /max cmdand they glom together?".Also closes #15193, which was introduced as a part of this.