Skip to content

Commit

Permalink
A hypothetical fix for hidden windows
Browse files Browse the repository at this point in the history
  We had a report in a mail thread that someone's Terminal windows were getting created hidden, and never showing themselves.

  As a theory, I'm guessing that dwFlags didn't say that we should actually use `wShowWindow`. So, to be more correct, let's actually obey that.

  I'm gonna send this package to them to see if it fixes them.

  Related to #14957.

  Likely regressed in #13838.
  • Loading branch information
zadjii-msft committed Apr 20, 2023
1 parent 2fd33ba commit fc38402
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/cascadia/WindowsTerminal/WindowEmperor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ bool WindowEmperor::HandleCommandlineArgs()
// so we can open a new window with the same state.
STARTUPINFOW si;
GetStartupInfoW(&si);
const auto showWindow = si.wShowWindow;
const uint32_t showWindow = WI_IsFlagSet(si.dwFlags, STARTF_USESHOWWINDOW) ? si.wShowWindow : SW_SHOW;

Remoting::CommandlineArgs eventArgs{ { args }, { cwd }, showWindow };

Expand Down

0 comments on commit fc38402

Please sign in to comment.