Localize the shell extension's menu item #10446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces localization for the "Open in Windows Terminal" menu item and differentiates it based on compile-time branding (rather than runtime detection!). @leonMSFT's tray icon pull request had the excellent idea to use the TerminalApp's resource compartment for auxiliary resources for projects that can't otherwise be localized the same way. Doing localization in the shell extension (or WindowsTerminal.exe) would require us to use MUIRCT and split the build process up to support mui files. That's a huge amount of work... but this is *not* a huge amount of work. Fixes #6112
DHowett
commented
Jun 17, 2021
| @@ -4,11 +4,11 @@ | |||
| #include "pch.h" | |||
| #include "OpenTerminalHere.h" | |||
| #include "../WinRTUtils/inc/WtExeUtils.h" | |||
| #include "../WinRTUtils/inc/LibraryResources.h" | |||
There was a problem hiding this comment.
this whole project is pretty much one and a half .cpp files. Is there value in having this in the PCH? Maybe.
leonMSFT
approved these changes
Jun 17, 2021
carlos-zamora
approved these changes
Jun 17, 2021
|
@msftbot merge this in 1 minute |
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
DHowett
added a commit
that referenced
this pull request
Jul 7, 2021
This commit introduces localization for the "Open in Windows Terminal" menu item and differentiates it based on compile-time branding (rather than runtime detection!). @leonMSFT's tray icon pull request had the excellent idea to use the TerminalApp's resource compartment for auxiliary resources for projects that can't otherwise be localized the same way. Doing localization in the shell extension (or WindowsTerminal.exe) would require us to use MUIRCT and split the build process up to support mui files. That's a huge amount of work... but this is *not* a huge amount of work. Fixes #6112 (cherry picked from commit b659321) # Conflicts: # src/cascadia/TerminalApp/Resources/en-US/Resources.resw
DHowett
added a commit
that referenced
this pull request
Jul 7, 2021
This commit introduces localization for the "Open in Windows Terminal" menu item and differentiates it based on compile-time branding (rather than runtime detection!). @leonMSFT's tray icon pull request had the excellent idea to use the TerminalApp's resource compartment for auxiliary resources for projects that can't otherwise be localized the same way. Doing localization in the shell extension (or WindowsTerminal.exe) would require us to use MUIRCT and split the build process up to support mui files. That's a huge amount of work... but this is *not* a huge amount of work. Fixes #6112 (cherry picked from commit b659321)
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces localization for the "Open in Windows Terminal"
menu item and differentiates it based on compile-time branding (rather
than runtime detection!).
@leonMSFT's tray icon pull request had the excellent idea to use the
TerminalApp's resource compartment for auxiliary resources for projects
that can't otherwise be localized the same way. Doing localization in
the shell extension (or WindowsTerminal.exe) would require us to use
MUIRCT and split the build process up to support mui files. That's a
huge amount of work... but this is not a huge amount of work.
Fixes #6112