Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The strings in the explorer context menu entry need to be localized #6112

Closed
zadjii-msft opened this issue May 21, 2020 · 2 comments · Fixed by #10446
Closed

The strings in the explorer context menu entry need to be localized #6112

zadjii-msft opened this issue May 21, 2020 · 2 comments · Fixed by #10446
Assignees
@DHowett
Labels
Area-Localization Area-ShellExtension For issues related to the explorer right-click context menu Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

Follow up from #6100.

Those strings are hardcoded right now - they should use localizable resources like the rest of our projects. Unsure about how exactly the best way to do that would be.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 21, 2020
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels May 21, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 21, 2020
@zadjii-msft zadjii-msft added Severity-Blocking We won't ship a release like this! No-siree. Area-Localization labels May 21, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 21, 2020
@zadjii-msft zadjii-msft added Area-ShellExtension For issues related to the explorer right-click context menu and removed Area-UserInterface Issues pertaining to the user interface of the Console or Terminal labels May 28, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 28, 2020
@miniksa miniksa added Area-ShellExtension For issues related to the explorer right-click context menu and removed Area-ShellExtension For issues related to the explorer right-click context menu labels Jun 19, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 19, 2020
@zadjii-msft zadjii-msft mentioned this issue Jul 27, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Feb 23, 2021
Closed
@mooons mooons mentioned this issue Mar 3, 2021
Closed
6 tasks
DHowett added a commit that referenced this issue Jun 17, 2021
@DHowett
Localize the shell extension menu item
76176f6 
This commit introduces localization for the "Open in Windows Terminal"
menu item and differentiates it based on compile-time branding (rather
than runtime detection!).

@leonMSFT's tray icon pull request had the excellent idea to use the
TerminalApp's resource compartment for auxiliary resources for projects
that can't otherwise be localized the same way. Doing localization in
the shell extension (or WindowsTerminal.exe) would require us to use
MUIRCT and split the build process up to support mui files. That's a
huge amount of work... but this is *not* a huge amount of work.

Fixes #6112
@DHowett DHowett mentioned this issue Jun 17, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Jun 17, 2021
@DHowett DHowett mentioned this issue Jun 17, 2021
Closed
@ghost ghost closed this as completed in #10446 Jun 17, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jun 17, 2021
ghost pushed a commit that referenced this issue Jun 17, 2021
@DHowett
Localize the shell extension's menu item (#10446)
b659321 
This commit introduces localization for the "Open in Windows Terminal"
menu item and differentiates it based on compile-time branding (rather
than runtime detection!).

@leonMSFT's tray icon pull request had the excellent idea to use the
TerminalApp's resource compartment for auxiliary resources for projects
that can't otherwise be localized the same way. Doing localization in
the shell extension (or WindowsTerminal.exe) would require us to use
MUIRCT and split the build process up to support mui files. That's a
huge amount of work... but this is *not* a huge amount of work.

Fixes #6112
DHowett added a commit that referenced this issue Jul 7, 2021
@DHowett
Localize the shell extension's menu item (#10446)
9a2a9db 
This commit introduces localization for the "Open in Windows Terminal"
menu item and differentiates it based on compile-time branding (rather
than runtime detection!).

@leonMSFT's tray icon pull request had the excellent idea to use the
TerminalApp's resource compartment for auxiliary resources for projects
that can't otherwise be localized the same way. Doing localization in
the shell extension (or WindowsTerminal.exe) would require us to use
MUIRCT and split the build process up to support mui files. That's a
huge amount of work... but this is *not* a huge amount of work.

Fixes #6112

(cherry picked from commit b659321)

# Conflicts:
#	src/cascadia/TerminalApp/Resources/en-US/Resources.resw
DHowett added a commit that referenced this issue Jul 7, 2021
@DHowett
Localize the shell extension's menu item (#10446)
3042ac5 
This commit introduces localization for the "Open in Windows Terminal"
menu item and differentiates it based on compile-time branding (rather
than runtime detection!).

@leonMSFT's tray icon pull request had the excellent idea to use the
TerminalApp's resource compartment for auxiliary resources for projects
that can't otherwise be localized the same way. Doing localization in
the shell extension (or WindowsTerminal.exe) would require us to use
MUIRCT and split the build process up to support mui files. That's a
huge amount of work... but this is *not* a huge amount of work.

Fixes #6112

(cherry picked from commit b659321)
@ghost
Copy link

ghost commented Jul 14, 2021

🎉This issue was addressed in #10446, which has now been successfully released as Windows Terminal v1.9.1942.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 14, 2021

🎉This issue was addressed in #10446, which has now been successfully released as Windows Terminal Preview v1.10.1933.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-Localization Area-ShellExtension For issues related to the explorer right-click context menu Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Localize the shell extension's menu item microsoft/terminal
4 participants
@DHowett @miniksa @zadjii-msft @cinnamon-msft