Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number parameters in Powershell are barely visible under light color schemes. #9673

Closed
CyanideCentral opened this issue Mar 31, 2021 · 2 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@CyanideCentral
Copy link

Environment

Windows version: 18363.1440
Terminal version: 1.6.10571.0

Steps to reproduce

Set color theme to light color schemes, such as One Half Light, Tango Light or 3rd party light themes.
Enter command "abcd 1234" in a Powershell tab, or simply "1234". Weirdly this doesn't happen in CMD tabs.

Expected behavior

I should be able to see the number displayed on screen.

Actual behavior

I can barely tell the number from the white background. Effects of entering "abcd 1234":

One Half Light

image
I actually entered '1234' after the 'abcd '.

Tango Light

image
Slightly better, but not clear at all.

Proposed solution

Change the color setting for numbers entered in Powershell.

Related to

#8033 #8716

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 31, 2021
@skyline75489
Copy link
Collaborator

As Dustin pointed out in #8033 (comment) , this is actually by design. You'll need to do some configuring to make the color-emitting application more suitable for your needs.

@zadjii-msft
Copy link
Member

Yea, this is by design. PSReadline's default config for text attributes doesn't really work all that well with light themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants