Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some parts of One Half Light and Solarized Light color scheme are barely visible #8033

Closed
vincentmathis opened this issue Oct 24, 2020 · 3 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.

Comments

@vincentmathis
Copy link

vincentmathis commented Oct 24, 2020

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 1.3.2651.0

Steps to reproduce

In settings set colorScheme: "One Half Light" and enter any command with a dot or select any text:

One Half Light

How it looks in One Half Dark:

One Half Dark

Expected Behavior

Text and text selection should be easily visible.

Notes

The background color is #FAFAFA while the bright text color is #FCFCFC according to colorpicker.

The same problem is visible in Solarized Light.

Setting a custom colorscheme where brightWhite is set to something dark turns the .Milliseconds part dark.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 24, 2020
@vincentmathis vincentmathis changed the title Some parts of One Half Light color scheme are barely visible Some parts of One Half Light and Solarized Light color scheme are barely visible Oct 24, 2020
@DHowett
Copy link
Member

DHowett commented Oct 24, 2020

This is, unfortunately, by design. The shell (in this case PowerShell as configured through Set-PSReadlineOption) and the color scheme have to cooperate, and right now PowerShell is explicitly asking for "bright white" (97m).

MemberColor                            : "`e[97m"

Unfortunately, color schemes are not immediately fungible. You'll need to do some configuring to make the color-emitting application more suitable for your needs. 😄

@DHowett DHowett closed this as completed Oct 24, 2020
@DHowett DHowett added the Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. label Oct 24, 2020
@SiqingYu
Copy link

Any workaround? Text selection and find results (Ctrl+F) are barely visible in light themes.

@SiqingYu
Copy link

I found this works well for lightbackground themes:

"selectionBackground": "#000000"

https://docs.microsoft.com/en-us/windows/terminal/customize-settings/color-schemes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.
Projects
None yet
Development

No branches or pull requests

3 participants