Alt arrow keys do nothing; key unbinding broken? #3729

paulwhiting · 2019-11-27T05:11:32Z

Environment

Windows build number: 10.0.18362.0
Windows Terminal version:  0.7.3291.0

Any other software?
- Ubuntu 16.04.3 LTS
- byobu version 5.106
- tmux 2.1

Note

This issue is a follow-on to #3101. In that issue superfluous keys were being generated. Now it appears no keys are being generated. Alt arrows are dead to me.

Steps to reproduce

Start Byobu: byobu
Create a new Byobu tab: F2
Press alt left or alt right to switch between the tabs

Expected behavior

Byobu switches between the two tabs.

Actual behavior

Nothing happens.

The text was updated successfully, but these errors were encountered:

paulwhiting · 2019-11-27T05:19:47Z

This behavior is due to #3585. Proper expected behavior is restored with the following:

    "keybindings": [
	{ "command": "unbound", "keys": [ "alt+shift+-" ] },
        { "command": "unbound", "keys": [ "alt+shift+plus" ] },
        { "command": "unbound", "keys": [ "alt+down" ] },
        { "command": "unbound", "keys": [ "alt+left" ] },
        { "command": "unbound", "keys": [ "alt+right" ] },
        { "command": "unbound", "keys": [ "alt+up" ] },
        { "command": "unbound", "keys": [ "alt+shift+down" ] },
        { "command": "unbound", "keys": [ "alt+shift+left" ] },
        { "command": "unbound", "keys": [ "alt+shift+right" ] },
        { "command": "unbound", "keys": [ "alt+shift+up" ] }
    ]

sivaramn · 2019-11-27T15:39:09Z

This behavior is due to #3585. Proper expected behavior is restored with the following:

    "keybindings": [
	{ "command": "unbound", "keys": [ "alt+shift+-" ] },
        { "command": "unbound", "keys": [ "alt+shift+plus" ] },
        { "command": "unbound", "keys": [ "alt+down" ] },
        { "command": "unbound", "keys": [ "alt+left" ] },
        { "command": "unbound", "keys": [ "alt+right" ] },
        { "command": "unbound", "keys": [ "alt+up" ] },
        { "command": "unbound", "keys": [ "alt+shift+down" ] },
        { "command": "unbound", "keys": [ "alt+shift+left" ] },
        { "command": "unbound", "keys": [ "alt+shift+right" ] },
        { "command": "unbound", "keys": [ "alt+shift+up" ] }
    ]

I also have the same issue. Do we have to unbind the keys for tmux to work? And what about mouse-focus? Prior to this release, in tmux clicking with mouse on any pane would focus the cursor in that pane. Now apparently that's gone. How does one restore mouse clicky behaviour ?

zadjii-msft · 2019-11-27T15:46:04Z

I'm confident that clicking in a pane in tmux never worked in the Windows Terminal, since we don't yet support mouse mode (#376, #545)...

sivaramn · 2019-11-27T15:50:01Z

I'm confident that clicking in a pane in tmux never worked in the Windows Terminal, since we don't yet support mouse mode (#376, #545)...

thanks for that. I could be mistaken, as I use versions of tmux in wsl & cygwin using mintty.

And the key unbounding didn't work. I'm still not able to use the alt keys to switch panes

zadjii-msft · 2019-11-27T16:02:39Z

@sivaramn what exactly do you have in your profiles.json, and what's in your tmux.conf?

sivaramn · 2019-11-27T16:07:12Z

bind -n M-Left select-pane -L
bind -n M-Right select-pane -R
bind -n M-Up select-pane -U
bind -n M-Down select-pane -D
bind -n S-Left  previous-window
bind -n S-Right next-window

that's in .tmux.conf

in profiles.json

 // Add any keybinding overrides to this array.
    // To unbind a default keybinding, set the command to "unbound"
    "keybindings": [{ "unbound": "nextTab", "keys": ["ctrl+tab"] },
		    {"command": "paste","keys": ["shift+insert"]},
		    //{ "keys": ["shift+insert"], "command": "paste" },
                    { "keys": ["ctrl+shift+v"], "command": "paste" },
		    { "command": "unbound", "keys": [ "alt+shift+-" ] },
       		    { "command": "unbound", "keys": [ "alt+shift+plus" ] },
       		    { "command": "unbound", "keys": [ "alt+down" ] },
       		    { "command": "unbound", "keys": [ "alt+left" ] },
                    { "command": "unbound", "keys": [ "alt+right" ] },
                    { "command": "unbound", "keys": [ "alt+up" ] },
                    { "command": "unbound", "keys": [ "alt+shift+down" ] },
                    { "command": "unbound", "keys": [ "alt+shift+left" ] },
                    { "command": "unbound", "keys": [ "alt+shift+right" ] },
                    { "command": "unbound", "keys": [ "alt+shift+up" ] }
			
                   ]
}

samba2 · 2019-12-11T11:48:32Z

...
       		    { "command": "unbound", "keys": [ "alt+down" ] },
       		    { "command": "unbound", "keys": [ "alt+left" ] },
                    { "command": "unbound", "keys": [ "alt+right" ] },
                    { "command": "unbound", "keys": [ "alt+up" ] },
                    { "command": "unbound", "keys": [ "alt+shift+down" ] },
                    { "command": "unbound", "keys": [ "alt+shift+left" ] },
                    { "command": "unbound", "keys": [ "alt+shift+right" ] },
                    { "command": "unbound", "keys": [ "alt+shift+up" ] }
                   ]
}

Just want do confirm that unbinding the alt key bindings worked for me. tmux resizing is now working as expected.

demfabris · 2020-01-08T18:51:36Z

Thank you so much for this!
This is an issue with Tmux alt key commands too.

finlaybob · 2020-03-09T12:51:44Z

Thanks for the example keybindings. Adding the unbound entries helped with behaviour in micro, which uses "alt+direction" by default for moving word at a time.

paulwhiting · 2020-03-18T00:52:11Z

Reopening issue because my alt-arrow buttons stopped working after upgrading Terminal to 0.10.761.0.

Windows build number: 10.0.18363.720
Windows Terminal version: 0.10.761.0

Any other software?

Ubuntu 16.04.6 LTS
byobu version 5.106
tmux 2.1

DHowett-MSFT · 2020-03-18T00:59:54Z

Yep, fair enough. Bet we broke this with VT input tunneling.

DHowett-MSFT · 2020-03-18T01:02:27Z

Actually, no, I think we broke unbinding. /cc @zadjii-msft.

yveslange · 2020-03-18T08:55:34Z

Same issue :)
ALT-LEFT, RIGHT, TOP, DOWN does not react. Really feel that the "unbounds" are not working anymore.

zadjii-msft · 2020-03-18T13:48:50Z

looking now

## Summary of the Pull Request We (the royal "we") broke key unbinding in #4746. We didn't run the local tests after this, which actually would have caught this. The comment even suggests what we should have done here. We need to make sure that when we bail, it's because there's a parsing function that returned nothing. `null`, `"unbound"`, etc actually don't even have a parsing function at all, so they should just keep on keepin' on. ## References Source of this regression: #4746 ## PR Checklist * [x] Closes #3729 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments This is a great example of why your unittests should run in CI always ## Validation Steps Performed * **ran the tests** * tested the following unbindings: ```json { "command": null, "keys": [ "ctrl+shift+t" ] }, { "command": "unbound", "keys": [ "ctrl+shift+t" ] }, { "command": "null", "keys": [ "ctrl+shift+t" ] }, ``` and they each individually worked.

## Summary of the Pull Request We (the royal "we") broke key unbinding in #4746. We didn't run the local tests after this, which actually would have caught this. The comment even suggests what we should have done here. We need to make sure that when we bail, it's because there's a parsing function that returned nothing. `null`, `"unbound"`, etc actually don't even have a parsing function at all, so they should just keep on keepin' on. ## References Source of this regression: #4746 ## PR Checklist * [x] Closes #3729 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments This is a great example of why your unittests should run in CI always ## Validation Steps Performed * **ran the tests** * tested the following unbindings: ```json { "command": null, "keys": [ "ctrl+shift+t" ] }, { "command": "unbound", "keys": [ "ctrl+shift+t" ] }, { "command": "null", "keys": [ "ctrl+shift+t" ] }, ``` and they each individually worked. (cherry picked from commit 8211ed9)

onefuncman · 2020-05-27T13:18:23Z

Why is this the default behavior? Seems like a bad UX -- what's the tradeoff?

edit: nevermind, i see the conflict with Panes functionality now

zadjii-msft · 2020-05-27T13:23:57Z

You know, you've just inspired an idea - if the user has no panes, then the Terminal could probably pass the Alt+Arrow through, similar to the way that Ctrl+C for copy sends a ^C when there's no text selected.

ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 27, 2019

paulwhiting changed the title ~~Alt arrow keys do nothing.~~ Alt arrow keys do nothing Nov 27, 2019

paulwhiting closed this as completed Nov 27, 2019

DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 10, 2019

paulwhiting reopened this Mar 18, 2020

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 18, 2020

DHowett-MSFT mentioned this issue Mar 18, 2020

Tmux: Custom config - Alt/Meta+(arrow key) for switching between panes doesn't work #4763

Closed

DHowett-MSFT changed the title ~~Alt arrow keys do nothing~~ Alt arrow keys do nothing; key unbinding broken? Mar 18, 2020

DHowett-MSFT added this to the Terminal v1.0 milestone Mar 18, 2020

DHowett-MSFT pinned this issue Mar 18, 2020

zadjii-msft self-assigned this Mar 18, 2020

zadjii-msft mentioned this issue Mar 18, 2020

Fix unbinding keys in v0.10 #4988

Merged

3 tasks

ghost added the In-PR This issue has a related PR label Mar 18, 2020

zadjii-msft mentioned this issue Mar 18, 2020

Unbound No Longer Respected For Keybindings #4989

Closed

zadjii-msft closed this as completed in #4988 Mar 18, 2020

ghost added the Needs-Tag-Fix Doesn't match tag requirements label Mar 18, 2020

ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 18, 2020

DHowett-MSFT unpinned this issue Mar 24, 2020

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 24, 2020

zadjii-msft mentioned this issue May 27, 2020

Pass through moveFocus keys when the user has no panes #6219

Closed

zadjii-msft mentioned this issue Sep 22, 2021

Add the ability to interact with subtrees of panes #11153

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alt arrow keys do nothing; key unbinding broken? #3729

Alt arrow keys do nothing; key unbinding broken? #3729

paulwhiting commented Nov 27, 2019

paulwhiting commented Nov 27, 2019 •

edited

Loading

sivaramn commented Nov 27, 2019

zadjii-msft commented Nov 27, 2019

sivaramn commented Nov 27, 2019

zadjii-msft commented Nov 27, 2019

sivaramn commented Nov 27, 2019

samba2 commented Dec 11, 2019

demfabris commented Jan 8, 2020

finlaybob commented Mar 9, 2020

paulwhiting commented Mar 18, 2020

DHowett-MSFT commented Mar 18, 2020

DHowett-MSFT commented Mar 18, 2020

yveslange commented Mar 18, 2020

zadjii-msft commented Mar 18, 2020

onefuncman commented May 27, 2020 •

edited

Loading

zadjii-msft commented May 27, 2020

Alt arrow keys do nothing; key unbinding broken? #3729

Alt arrow keys do nothing; key unbinding broken? #3729

Comments

paulwhiting commented Nov 27, 2019

Environment

Note

Steps to reproduce

Expected behavior

Actual behavior

paulwhiting commented Nov 27, 2019 • edited Loading

sivaramn commented Nov 27, 2019

zadjii-msft commented Nov 27, 2019

sivaramn commented Nov 27, 2019

zadjii-msft commented Nov 27, 2019

sivaramn commented Nov 27, 2019

samba2 commented Dec 11, 2019

demfabris commented Jan 8, 2020

finlaybob commented Mar 9, 2020

paulwhiting commented Mar 18, 2020

DHowett-MSFT commented Mar 18, 2020

DHowett-MSFT commented Mar 18, 2020

yveslange commented Mar 18, 2020

zadjii-msft commented Mar 18, 2020

onefuncman commented May 27, 2020 • edited Loading

zadjii-msft commented May 27, 2020

paulwhiting commented Nov 27, 2019 •

edited

Loading

onefuncman commented May 27, 2020 •

edited

Loading