Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Summary of the Pull Request We (the royal "we") broke key unbinding in #4746. We didn't run the local tests after this, which actually would have caught this. The comment even suggests what we should have done here. We need to make sure that when we bail, it's because there's a parsing function that returned nothing. `null`, `"unbound"`, etc actually don't even have a parsing function at all, so they should just keep on keepin' on. ## References Source of this regression: #4746 ## PR Checklist * [x] Closes #3729 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments This is a great example of why your unittests should run in CI always ## Validation Steps Performed * **ran the tests** * tested the following unbindings: ```json { "command": null, "keys": [ "ctrl+shift+t" ] }, { "command": "unbound", "keys": [ "ctrl+shift+t" ] }, { "command": "null", "keys": [ "ctrl+shift+t" ] }, ``` and they each individually worked.
- Loading branch information