Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brightBlack and black color values from Solarized Dark Color Scheme are swapped #14684

Closed
nachopitt opened this issue Jan 15, 2023 · 2 comments
Closed
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.

Comments

@nachopitt
Copy link

Windows Terminal version

1.15.3465.0

Windows build number

No response

Other Software

VSCode 1.74.2 with Solarized Dark Color Theme selected
vim 8.1.2262 (inside WSL2)
colortest-256

Steps to reproduce

According to the colors table in https://en.wikipedia.org/wiki/Solarized

image

the Solarized Dark Color Scheme default values should be
black = #073642
brBlack = #002b36

In VSCode Terminal running in WSL2: Ubuntu-20.04 the color schema seems to be correct. But running the same WSL2 Distro but this time in Windows Terminal, the black and brBlack colors are swapped.

You can visually confirm this by running the colortest-256 test application on both environments:

VSCode Terminal:
image

Windows Terminal:
image

Expected Behavior

Both VSCode and Windows Terminal should be able to reproduce the same colors when selecting the same Color Theme/Schema (In this case, Solarized Dark).

I know this can be easily solved at "user configuration" level, but it would be better to have the correct values by default.

Actual Behavior

By using vim, the color swap effect is more noticeable

VSCode Terminal
image

Windows Terminal
image

@nachopitt nachopitt added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 15, 2023
@j4james
Copy link
Collaborator

j4james commented Jan 15, 2023

The black and brightBlack colors were deliberately swapped in PR #6985 to try and cut down on the constant stream of bug reports we were receiving from people using the Solarized color schemes, because the default mapping tends to produce color combinations that are invisible.

@zadjii-msft
Copy link
Member

DAYS SINCE I'VE REGRETTED SHIPPING SOLARIZED: 195 0

Thanks for the callback @j4james, I totally forgot about that PR. I'll concur, this is by design.

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2023
@zadjii-msft zadjii-msft added the Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.
Projects
None yet
Development

No branches or pull requests

3 participants