-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle terminal color schemes #17
Comments
there are two thoughts that come to mind for potential fixes:
I personally feel like 1 would be the better pick here when thinking about UX. Less of "it works on my machine" 😆 |
facepalm nice find @Waldeedle colors in the terminal are a tricky beast. to your point of number 2, we can't actually do calculations on the colors, because we can't know what the colors are. (There are some control codes to query color schemes, but they are non-standard and unimplemented in a lot of terminals. plus, they don't always give you a definitive answer anyway) I think the best option would be to just add some configurability here - then people can tweak the colors if needed. for now, we do respect the |
Ah right, I totally overlooked that since this is a CLI application, it can allow users to use a config file to override colors. That would also allow users additional customization. Customizability FTW As for your comment about point 2, definitely was thinking the solution would be very abstract (was hoping lipgloss might surface hex codes or rgb values even from ANSI values). 👏👏👏 |
this will be resolved in the next release i have added a related commit: 28fa134 |
Feedback:
Should we maybe add a --no-color option? Idk the "normal" way to handle this, maybe @cgsdev0 has some ideas
The text was updated successfully, but these errors were encountered: