Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solarized Light scheme is not correct. #13383

Closed
kgfly opened this issue Jun 26, 2022 · 1 comment
Closed

Solarized Light scheme is not correct. #13383

kgfly opened this issue Jun 26, 2022 · 1 comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered

Comments

@kgfly
Copy link

kgfly commented Jun 26, 2022 •
edited
Loading

Windows Terminal version

1.13.11431.0

Windows build number

10.0.19044.1766

Other Software

No response

Steps to reproduce

In VS22 dev profile, add

            "colorScheme": "Solarized Light",

Expected Behavior

For warning string, the font color does not have any special color.

image

Actual Behavior

waring string should have a different color than normal font color. etc, in above, blue circle should different color than red circle
@kgfly kgfly added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jun 26, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 26, 2022
@zadjii-msft
Copy link
Member

DAYS SINCE I'VE REGRETTED SHIPPING SOLARIZED: 301 0

I'm suspecting that this tool is outputting text in "bright yellow", which in the default Solarized scheme is basically just gray.

image

Alas, by design, solarized doesn't have both a bright and dark yellow - it's only got one yellow. We're following the Solarized spec here, but feel free to modify it by hand to have both yellow and brightYellow be the same value.

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2022
@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered labels Jul 5, 2022
@zadjii-msft zadjii-msft mentioned this issue Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgfly @zadjii-msft