Windows App SDK 1.0.0 stable #9177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
2 tasks
2 tasks
asklar
reviewed
Mar 16, 2022
asklar
suggested changes
Mar 16, 2022
change/@react-native-windows-cli-0a3694bd-552a-430f-9124-1b56ff6df6e9.json
Outdated
Show resolved
Hide resolved
packages/@react-native-windows/cli/src/generator-windows/index.ts
Outdated
Show resolved
Hide resolved
packages/@react-native-windows/cli/src/runWindows/utils/deploy.ts
Outdated
Show resolved
Hide resolved
vnext/template/cs-app-WinAppSDK/proj/ExperimentalFeatures.props
Outdated
Show resolved
Hide resolved
ci build failing
asklar
approved these changes
Mar 19, 2022
| ) | ||
| return importProjectExists( | ||
| projectContents, | ||
| 'Microsoft.ReactNative.Uwp.CSharpApp.targets', |
There was a problem hiding this comment.
looks like you removed the check for importing Microsoft.ReactNative.WinAppSDK.CSharpApp.props, was that intended?
There was a problem hiding this comment.
Yeah I ended up reverting to the logic we had previously because the check for importing WASDK started failing and so the CLI wouldn't build. Using this for now as it works, and plan to update/try checking for a targets file like UWP does once we add a targets file for WASDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Microsoft.ReactNative.WindowsAppSDK building on WinAppSDK 1.0.0 🎉 This Includes a template app (C#, MSIX packaged) and the E2E CLI logic for said app to be generated and built using the
--usewinui3flag, currently needs to be deployed from VS.Closes:
Partially addresses:
Type of Change
Microsoft Reviewers: Open in CodeFlow