Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit imports of RNW props/targets when consuming RNW from NuGet #9712

Open
AgneLukoseviciute opened this issue Mar 17, 2022 · 0 comments
Open

Remove explicit imports of RNW props/targets when consuming RNW from NuGet #9712

AgneLukoseviciute opened this issue Mar 17, 2022 · 0 comments
Labels
Code Cleanup enhancement PackageReference Modern NuGet restore used in C++ projects PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) Workstream: New Arch NuGet Refactor Create new architecture NuGet packages that exclude old architecture types and dependencies.
Milestone
Backlog

Comments

@AgneLukoseviciute
Copy link
Contributor

Now that we have PackageReference for C++ and C#, we can probably remove the need for explicit Imports of the RNW props/targets when consuming from NuGet (like in the winappsdk case) and have the project system include the props/targets automatically.
We'd still need to import them when building from source though.

Originally posted by @asklar in #9177 (comment)
@AgneLukoseviciute AgneLukoseviciute added enhancement PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) labels Mar 17, 2022
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Mar 17, 2022
@AgneLukoseviciute AgneLukoseviciute added the PackageReference Modern NuGet restore used in C++ projects label Mar 17, 2022
@AgneLukoseviciute AgneLukoseviciute mentioned this issue Mar 17, 2022
Merged
@chrisglein chrisglein added Code Cleanup and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Mar 17, 2022
@chrisglein chrisglein added this to the Backlog milestone Mar 17, 2022
@chiaramooney chiaramooney added the Workstream: New Arch NuGet Refactor Create new architecture NuGet packages that exclude old architecture types and dependencies. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Cleanup enhancement PackageReference Modern NuGet restore used in C++ projects PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) Workstream: New Arch NuGet Refactor Create new architecture NuGet packages that exclude old architecture types and dependencies.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@chrisglein @chiaramooney @AgneLukoseviciute @TatianaKapos