Disconnect IO handles during PtyKill #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref microsoft/vscode#123056
I noticed some handles were still being left open after killing a pwsh terminal in VS Code. This PR closes the
hInandhOuthandles duringPtyKill. I'm currently following the docs at https://docs.microsoft.com/en-us/windows/win32/ipc/named-pipe-operations, which suggest that the server can callDisconnectNamedPipe, and then callCloseHandleafter.Note that this fix at most helps with some cleanup during
PtyKill, but it doesn't solve anything regardingPtyConnect.Before merging:
automatic flow controlitem. But, the same was happening for me even without the changes in this PR.