Merge pull request #510 from microsoft/rzhao271/close-iohandles

Disconnect IO handles during PtyKill
microsoft · Nov 12, 2021 · 256c59c · 256c59c
2 parents b7c76f2 + ba424e1
commit 256c59c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/win/conpty.cc b/src/win/conpty.cc
@@ -318,8 +318,8 @@ static NAN_METHOD(PtyConnect) {
   auto envV = vectorFromString(env);
   LPWSTR envArg = envV.empty() ? nullptr : envV.data();
 
-  BOOL success = ConnectNamedPipe(handle->hIn, nullptr);
-  success = ConnectNamedPipe(handle->hOut, nullptr);
+  ConnectNamedPipe(handle->hIn, nullptr);
+  ConnectNamedPipe(handle->hOut, nullptr);
 
   // Attach the pseudoconsole to the client application we're creating
   STARTUPINFOEXW siEx{0};
@@ -442,6 +442,10 @@ static NAN_METHOD(PtyKill) {
       }
     }
 
+    DisconnectNamedPipe(handle->hIn);
+    DisconnectNamedPipe(handle->hOut);
+    CloseHandle(handle->hIn);
+    CloseHandle(handle->hOut);
     CloseHandle(handle->hShell);
   }