Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Delete redundant code #3526

Merged
merged 4 commits into from
Apr 30, 2021
+0 −2
Merged

Delete redundant code #3526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25e8433
Update frameworkcontrollerTrainingService.ts
maxsuren Apr 12, 2021
b93ef7c
Update kubeflowTrainingService.ts
maxsuren Apr 12, 2021
a277d79
Update kubeflowTrainingService.ts
maxsuren Apr 12, 2021
470ccb5
Update frameworkcontrollerTrainingService.ts
maxsuren Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ger/training_service/kubernetes/frameworkcontroller/frameworkcontrollerTrainingService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ class FrameworkControllerTrainingService extends KubernetesTrainingService imple
await this.fcJobInfoCollector.retrieveTrialStatus(this.kubernetesCRDClient);
if (this.kubernetesJobRestServer.getErrorMessage !== undefined) {
throw new Error(this.kubernetesJobRestServer.getErrorMessage);
this.stopping = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems better to move this in front of the throw new Error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello J-shang, I thought about this at the beginning, but than I realized this.stopping never been assigned to true in the old logic, so if I move this.stopping=true to the front of throw new Error, this.stopping will be true when throwing Error and the old logic will be broken.

}
}
}
Expand Down
1 change: 0 additions & 1 deletion ts/nni_manager/training_service/kubernetes/kubeflow/kubeflowTrainingService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ class KubeflowTrainingService extends KubernetesTrainingService implements Kuber
await this.kubeflowJobInfoCollector.retrieveTrialStatus(this.kubernetesCRDClient);
if (this.kubernetesJobRestServer.getErrorMessage !== undefined) {
throw new Error(this.kubernetesJobRestServer.getErrorMessage);
this.stopping = true;
}
}
this.log.info('Kubeflow training service exit.');
Expand Down