This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Delete redundant code #3526
Merged
Delete redundant code #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
J-shang
reviewed
Apr 14, 2021
| @@ -65,7 +65,6 @@ class FrameworkControllerTrainingService extends KubernetesTrainingService imple | |||
| await this.fcJobInfoCollector.retrieveTrialStatus(this.kubernetesCRDClient); | |||
| if (this.kubernetesJobRestServer.getErrorMessage !== undefined) { | |||
| throw new Error(this.kubernetesJobRestServer.getErrorMessage); | |||
| this.stopping = true; | |||
There was a problem hiding this comment.
Seems better to move this in front of the throw new Error.
There was a problem hiding this comment.
Hello J-shang, I thought about this at the beginning, but than I realized this.stopping never been assigned to true in the old logic, so if I move this.stopping=true to the front of throw new Error, this.stopping will be true when throwing Error and the old logic will be broken.
SparkSnail
approved these changes
Apr 28, 2021
J-shang
approved these changes
Apr 29, 2021
49 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete redundant code in:
ts/nni_manager/training_service/kubernetes/frameworkcontroller/frameworkcontrollerTrainingService.ts
ts/nni_manager/training_service/kubernetes/kubeflow/kubeflowTrainingService.ts
These lines will never be reached