Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SQLServerException constructors public #334

Conversation

xiangyushawn
Copy link
Contributor

re-create PR #247

@codecov-io
Copy link

Codecov Report

Merging #334 into dev will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #334      +/-   ##
============================================
+ Coverage     37.22%   37.27%   +0.05%     
- Complexity     1662     1670       +8     
============================================
  Files           103      103              
  Lines         23673    23673              
  Branches       3882     3882              
============================================
+ Hits           8812     8825      +13     
+ Misses        13267    13258       -9     
+ Partials       1594     1590       -4
Flag Coverage Δ Complexity Δ
#JDBC41 37.06% <ø> (+0.05%) 1660 <ø> (+8) ⬆️
#JDBC42 37.17% <ø> (+0.01%) 1664 <ø> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerException.java 77.23% <ø> (+1.62%) 29 <0> (+1) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 47.79% <0%> (-1.48%) 9% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 45.15% <0%> (-0.71%) 60% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 46.04% <0%> (-0.24%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 48.97% <0%> (-0.15%) 210% <0%> (-1%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 33.62% <0%> (+0.17%) 90% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 37.03% <0%> (+0.27%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 27.61% <0%> (+0.37%) 189% <0%> (+2%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 30.13% <0%> (+1.11%) 57% <0%> (+3%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a9dfa...1ca5a0b. Read the comment docs.

@xiangyushawn xiangyushawn merged commit 98bfbc9 into microsoft:dev Jun 27, 2017
@xiangyushawn xiangyushawn deleted the Make-SQLServerException-constructors-public branch June 27, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants