Make SQLServerException constructors public

[phrxst]

No description provided.

[codecov-io]

Codecov Report

Merging #247 into dev will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #247      +/-   ##
============================================
+ Coverage     37.22%   37.23%   +<.01%     
- Complexity     1662     1668       +6     
============================================
  Files           103      103              
  Lines         23673    23673              
  Branches       3882     3882              
============================================
+ Hits           8812     8814       +2     
+ Misses        13267    13266       -1     
+ Partials       1594     1593       -1

Flag	Coverage Δ	Complexity Δ
#JDBC41	37.14% <ø> (+0.14%)	1662 <ø> (+10)	⬆️
#JDBC42	37.12% <ø> (-0.04%)	1664 <ø> (+4)

Impacted Files	Coverage Δ	Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerException.java	77.23% <ø> (+1.62%)	29 <0> (+1)	⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java	47.79% <0%> (-1.48%)	9% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java	45.15% <0%> (-0.71%)	60% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java	46.11% <0%> (-0.18%)	0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java	48.97% <0%> (-0.15%)	212% <0%> (+1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java	27.15% <0%> (-0.09%)	186% <0%> (-1%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java	33.62% <0%> (+0.17%)	90% <0%> (+1%)	⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java	37.03% <0%> (+0.27%)	0% <0%> (ø)	⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java	29.68% <0%> (+0.66%)	56% <0%> (+2%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a9dfa...db04f59. Read the comment docs.

[v-nisidh]

@mhaderman : Unfortunately your dev branch do not have fixes. Might be some fixes did not pushed to remote dev branch. I am keeping PR open so when you commit changes on DEV branch those commits will be reflect in this PR.

[v-nisidh]

@mhaderman : Instead of pushing changes from master to dev can you push changes from your dev to dev branch. May be you need to manually merge only your changes in your dev branch / branch which is forked from mssql-jdbc/dev and then used that branch to create pull request.

Ref: Merge pull request #3 from mhaderman/master

Sorry for inconvenience.

[xiangyushawn]

hello @mhaderman , thank you very much for your contribution. We decided to close this PR since the indentation does not match our formatter.

However, the implementation you made is great, therefore we created a new PR #334 that is identical to your implementation.

Thank you again for your contribution.